feedback

Author: geof90

CodePush.js

@@ -170,28 +170,28 @@ function setUpTestDependencies(testSdk, providedTestConfig, testNativeBridge) {
   if (testNativeBridge) NativeCodePush = testNativeBridge;
 }
 
-// This function allows sync operations to be chained on to each other so that they do not
+// This function allows calls to syncInternal to be chained on to each other so that they do not
 // interleave in the event that sync() is called multiple times.
 const sync = (() => {
   let syncPromiseChain = Promise.resolve();
   return (options = {}, syncStatusChangeCallback, downloadProgressCallback) => {
     syncPromiseChain = syncPromiseChain
       .catch(() => {})
-      .then(() => syncOperation(options, syncStatusChangeCallback, downloadProgressCallback));
+      .then(() => syncInternal(options, syncStatusChangeCallback, downloadProgressCallback));
     return syncPromiseChain;
   };
 })();
 
 /*
- * The syncOperation method provides a simple, one-line experience for
+ * The syncInternal method provides a simple, one-line experience for
  * incorporating the check, download and application of an update.
  * 
  * It simply composes the existing API methods together and adds additional
  * support for respecting mandatory updates, ignoring previously failed
  * releases, and displaying a standard confirmation UI to the end-user
  * when an update is available.
  */
-async function syncOperation(options = {}, syncStatusChangeCallback, downloadProgressCallback) {  
+async function syncInternal(options = {}, syncStatusChangeCallback, downloadProgressCallback) {  
   const syncOptions = {
 
     deploymentKey: null,

CodePush.m

@@ -506,6 +506,8 @@ - (void)savePendingUpdate:(NSString *)packageHash
 RCT_EXPORT_METHOD(notifyApplicationReady:(RCTPromiseResolveBlock)resolve
                                 rejecter:(RCTPromiseRejectBlock)reject)
 {
+    // We only mark a pending update as succeeded only if it update has been booted up,
+    // during which `_isFirstRunAfterUpdate` is true.
     if (_isFirstRunAfterUpdate) {
         [CodePush removePendingUpdate];
     }

android/app/src/main/java/com/microsoft/codepush/react/CodePush.java

@@ -539,10 +539,12 @@ public void isFirstRun(String packageHash, Promise promise) {
 
         @ReactMethod
         public void notifyApplicationReady(Promise promise) {
+            // We only mark a pending update as succeeded only if it update has been booted up,
+            // during which `didUpdate` is true.
             if (didUpdate) {
                 removePendingUpdate();
             }
-            
+
             promise.resolve("");
         }