Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Commit 359ab98

Browse files
cooperkaMax
authored andcommitted
Update the debug message for missing bundles (#923)
* Update the debug message in CodePush.m for missing bundles * Update text for updated RN PR * Add a real example of what to add to the script
1 parent d78956b commit 359ab98

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

ios/CodePush/CodePush.m

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -332,16 +332,19 @@ + (void)ensureBinaryBundleExists
332332
#ifdef DEBUG
333333
#if TARGET_IPHONE_SIMULATOR
334334
errorMessage = @"React Native doesn't generate your app's JS bundle by default when deploying to the simulator. "
335-
"If you'd like to test CodePush using the simulator, you can do one of three things depending on your React "
336-
"Native version and/or preferred workflow:\n\n"
335+
"If you'd like to test CodePush using the simulator, you can do one of the following depending on your "
336+
"React Native version and/or preferred workflow:\n\n"
337337

338338
"1. Update your AppDelegate.m file to load the JS bundle from the packager instead of from CodePush. "
339-
"You can still test your CodePush update experience using this workflow (debug builds only).\n\n"
339+
"You can still test your CodePush update experience using this workflow (Debug builds only).\n\n"
340340

341-
"2. Force the JS bundle to be generated in simulator builds by removing the if block that echoes "
342-
"\"Skipping bundling for Simulator platform\" in the \"node_modules/react-native/packager/react-native-xcode.sh\" file.\n\n"
341+
"2. Force the JS bundle to be generated in simulator builds by adding 'export FORCE_BUNDLING=true' to the script under "
342+
"\"Build Phases\" > \"Bundle React Native code and images\" (React Native >=0.48 only).\n\n"
343343

344-
"3. Deploy a release build to the simulator, which unlike debug builds, will generate the JS bundle (React Native >=0.22.0 only).";
344+
"3. Force the JS bundle to be generated in simulator builds by removing the if block that echoes "
345+
"\"Skipping bundling for Simulator platform\" in the \"node_modules/react-native/packager/react-native-xcode.sh\" file (React Native <=0.47 only)\n\n"
346+
347+
"4. Deploy a Release build to the simulator, which unlike Debug builds, will generate the JS bundle (React Native >=0.22.0 only).";
345348
#else
346349
errorMessage = [NSString stringWithFormat:@"The specified JS bundle file wasn't found within the app's binary. Is \"%@\" the correct file name?", [bundleResourceName stringByAppendingPathExtension:bundleResourceExtension]];
347350
#endif

0 commit comments

Comments
 (0)