Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Commit 36e90ac

Browse files
committed
feedback
1 parent 53073a5 commit 36e90ac

21 files changed

+51
-46
lines changed

Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/FirstUpdateTest.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@
22

33
import React from "react-native";
44
import CodePush from "react-native-code-push";
5-
const NativeCodePush = React.NativeModules.CodePush;
65
import createTestCaseComponent from "../../utils/createTestCaseComponent";
7-
const PackageMixins = require("react-native-code-push/package-mixins.js")(NativeCodePush);
86
import assert from "assert";
97
import createMockAcquisitionSdk from "../../utils/mockAcquisitionSdk";
10-
118
import { serverPackage } from "../resources/testPackages";
9+
10+
const NativeCodePush = React.NativeModules.CodePush;
11+
const PackageMixins = require("react-native-code-push/package-mixins.js")(NativeCodePush);
1212
const localPackage = {};
1313

1414
let FirstUpdateTest = createTestCaseComponent(

Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/NewUpdateTest.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@
22

33
import React from "react-native";
44
import CodePush from "react-native-code-push";
5-
const NativeCodePush = React.NativeModules.CodePush;
65
import createTestCaseComponent from "../../utils/createTestCaseComponent";
7-
const PackageMixins = require("react-native-code-push/package-mixins.js")(NativeCodePush);
86
import assert from "assert";
97
import createMockAcquisitionSdk from "../../utils/mockAcquisitionSdk";
10-
118
import { serverPackage, localPackage } from "../resources/testPackages";
129

10+
const NativeCodePush = React.NativeModules.CodePush;
11+
const PackageMixins = require("react-native-code-push/package-mixins.js")(NativeCodePush);
12+
1313
let NewUpdateTest = createTestCaseComponent(
1414
"NewUpdateTest",
1515
"should return an update when server has a package that is newer than the current one",

Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/NoRemotePackageTest.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22

33
import React from "react-native";
44
import CodePush from "react-native-code-push";
5-
const NativeCodePush = React.NativeModules.CodePush;
65
import createTestCaseComponent from "../../utils/createTestCaseComponent";
7-
const PackageMixins = require("react-native-code-push/package-mixins.js")(NativeCodePush);
86
import assert from "assert";
97
import createMockAcquisitionSdk from "../../utils/mockAcquisitionSdk";
108

9+
const NativeCodePush = React.NativeModules.CodePush;
10+
const PackageMixins = require("react-native-code-push/package-mixins.js")(NativeCodePush);
1111
const serverPackage = null;
1212
const localPackage = {};
1313

Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/RemotePackageAppVersionNewerTest.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@
22

33
import React from "react-native";
44
import CodePush from "react-native-code-push";
5-
const NativeCodePush = React.NativeModules.CodePush;
65
import createTestCaseComponent from "../../utils/createTestCaseComponent";
7-
const PackageMixins = require("react-native-code-push/package-mixins.js")(NativeCodePush);
86
import assert from "assert";
97
import createMockAcquisitionSdk from "../../utils/mockAcquisitionSdk";
10-
118
import { updateAppVersionPackage as serverPackage } from "../resources/testPackages";
9+
10+
const NativeCodePush = React.NativeModules.CodePush;
11+
const PackageMixins = require("react-native-code-push/package-mixins.js")(NativeCodePush);
1212
const localPackage = {};
1313

1414
let RemotePackageAppVersionNewerTest = createTestCaseComponent(

Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/SamePackageTest.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@
22

33
import React from "react-native";
44
import CodePush from "react-native-code-push";
5-
const NativeCodePush = React.NativeModules.CodePush;
65
import createTestCaseComponent from "../../utils/createTestCaseComponent";
7-
const PackageMixins = require("react-native-code-push/package-mixins.js")(NativeCodePush);
86
import assert from "assert";
97
import createMockAcquisitionSdk from "../../utils/mockAcquisitionSdk";
10-
118
import { serverPackage } from "../resources/testPackages";
9+
10+
const NativeCodePush = React.NativeModules.CodePush;
11+
const PackageMixins = require("react-native-code-push/package-mixins.js")(NativeCodePush);
1212
const localPackage = serverPackage;
1313

1414
let SamePackageTest = createTestCaseComponent(

Examples/CodePushDemoApp/CodePushDemoAppTests/CheckForUpdateTests/testcases/SwitchDeploymentKeyTest.js

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,14 @@
22

33
import React from "react-native";
44
import CodePush from "react-native-code-push";
5-
const NativeCodePush = React.NativeModules.CodePush;
65
import createTestCaseComponent from "../../utils/createTestCaseComponent";
7-
const PackageMixins = require("react-native-code-push/package-mixins.js")(NativeCodePush);
86
import assert from "assert";
97
import createMockAcquisitionSdk from "../../utils/mockAcquisitionSdk";
10-
118
import { serverPackage } from "../resources/testPackages";
12-
const localPackage = {};
139

10+
const NativeCodePush = React.NativeModules.CodePush;
11+
const PackageMixins = require("react-native-code-push/package-mixins.js")(NativeCodePush);
12+
const localPackage = {};
1413
const deploymentKey = "myKey123";
1514

1615
let SwitchDeploymentKeyTest = createTestCaseComponent(

Examples/CodePushDemoApp/CodePushDemoAppTests/DownloadProgressTests/DownloadProgressTestApp.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,13 @@
11
"use strict";
22

3-
import React from "react-native";
4-
5-
let {
3+
import React, {
64
AppRegistry,
75
ScrollView,
86
StyleSheet,
97
Text,
108
TouchableOpacity,
119
View,
12-
} = React;
10+
} from "react-native";
1311

1412
let TESTS = [
1513
require("./testcases/DownloadProgressTest")

Examples/CodePushDemoApp/CodePushDemoAppTests/DownloadProgressTests/testcases/DownloadProgressTest.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,14 @@
22

33
import React from "react-native";
44
import CodePush from "react-native-code-push";
5-
const NativeCodePush = React.NativeModules.CodePush;
65
import createTestCaseComponent from "../../utils/createTestCaseComponent";
7-
const PackageMixins = require("react-native-code-push/package-mixins.js")(NativeCodePush);
86
import assert from "assert";
9-
107
import testPackages from "../resources/TestPackages";
8+
9+
const NativeCodePush = React.NativeModules.CodePush;
10+
const PackageMixins = require("react-native-code-push/package-mixins.js")(NativeCodePush);
1111
const localPackage = {};
12+
1213
let saveProgress;
1314

1415
function checkReceivedAndExpectedBytesEqual() {

Examples/CodePushDemoApp/CodePushDemoAppTests/InstallUpdateTests/resources/CheckIsFirstRunAndPassTest.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import React, {
55
Text,
66
View,
77
} from "react-native";
8-
98
import CodePush from "react-native-code-push";
109

1110
let IsFirstRunTest = React.createClass({

Examples/CodePushDemoApp/CodePushDemoAppTests/InstallUpdateTests/resources/IsFailedUpdateTestBundleV1.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@ import React, {
66
Text,
77
View,
88
} from "react-native";
9-
109
import CodePush from "react-native-code-push";
10+
import createMockAcquisitionSdk from "../../utils/mockAcquisitionSdk";
11+
1112
const NativeCodePush = React.NativeModules.CodePush;
1213
const PackageMixins = require("react-native-code-push/package-mixins.js")(NativeCodePush);
13-
import createMockAcquisitionSdk from "../../utils/mockAcquisitionSdk";
1414

1515
let IsFailedUpdateTest = React.createClass({
1616
getInitialState() {

0 commit comments

Comments
 (0)