Moving restartApp to LocalPackage

Author: lostintangent

CodePush.ios.js

@@ -280,7 +280,6 @@ var CodePush = {
   getCurrentPackage: getCurrentPackage,
   log: log,
   notifyApplicationReady: NativeCodePush.notifyApplicationReady,
-  restartApp: NativeCodePush.restartApp,
   setUpTestDependencies: setUpTestDependencies,
   sync: sync,
   InstallMode: {

CodePush.m

@@ -346,18 +346,18 @@ - (void)startRollbackTimer:(int)rollbackTimeout
     resolve([NSNull null]);
 }
 
-RCT_EXPORT_METHOD(restartApp)
-{
-    [self checkForPendingUpdate:YES];
-}
-
 // This version of restart app is exposed solely for immediately installed
 // update support, and shouldn't be consumed directly by user code.
-RCT_EXPORT_METHOD(restartAppInternal:(int)rollbackTimeout)
+RCT_EXPORT_METHOD(restartForImmedidateUpdate:(int)rollbackTimeout)
 {
     [self initializeUpdateWithRollbackTimeout:rollbackTimeout needsRestart:YES];
 }
 
+RCT_EXPORT_METHOD(restartForPendingUpdate)
+{
+    [self checkForPendingUpdate:YES];
+}
+
 RCT_EXPORT_METHOD(setUsingTestFolder:(BOOL)shouldUseTestFolder)
 {
     usingTestFolder = shouldUseTestFolder;

README.md

@@ -125,7 +125,6 @@ When you require the `react-native-code-push` module, that object provides the f
 * [checkForUpdate](#codepushcheckforupdate): Queries the CodePush service for an update against the configured deployment. This method returns a promise which resolves to a `RemotePackage` that can be subsequently downloaded.
 * [getCurrentPackage](#codepushgetcurrentpackage): Gets information about the currently installed package (e.g. description, installation time)
 * [notifyApplicationReady](#codepushnotifyapplicationready): Notifies the CodePush runtime that an installed update is considered successful. This is an optional API, but is useful when you want to expicitly enable "rollback protection" in the event that an exception occurs in any code that you've deployed to production
-* [restartApp](#codepushrestartapp): Immediately restarts the app if a previously installed update is pending.
 * [sync](#codepushsync): Allows checking for an update, downloading it and installing it, all with a single call. Unless you need custom UI and/or behavior, we recommend most developers to use this method when integrating CodePush into their apps
 
 #### codePush.checkForUpdate
@@ -174,19 +173,6 @@ Notifies the CodePush runtime that an update is considered successful, and there
 
 If the `rollbackTimeout` parameter was not specified, the CodePush runtime will not enforce any automatic rollback behavior, and therefore, calling this function is not required and will result in a no-op.
 
-#### codePush.restartApp
-
-```javascript
-codePush.restartApp(): void;
-```
-
-Installs a pending update (if applicable) by immediately restarting the app, and optionally starting the rollback timer. This method is for advanced scenarios, and is useful when the following conditions are true:
-
-1. Your app is specifying an install mode value of `ON_NEXT_RESTART` or `ON_NEXT_RESUME` when calling `sync` or `LocalPackage.install`, which has the effect of not applying your update until the app has been restarted (by either the end-user or OS)
-2. You have an app-specific user event (e.g. the end-user navigated back to the app's home page) that allows you to apply the update in an unobtrusive way, and potentially gets the update in front of the end-user sooner then waiting until the next restart.
-
-If your app doesn't have a pending update, then calling this method results in a no-op. Otherwise, calling it will restart the app and start the rollback timer based on the timeout value that was specified in the previous call to `sync` or `LocalPackage.install`. 
-
 #### codePush.sync
 
 ```javascript

package-mixins.js

@@ -40,7 +40,11 @@ module.exports = (NativeCodePush) => {
         .then(function() {
           updateInstalledCallback && updateInstalledCallback();
           if (installMode == NativeCodePush.codePushInstallModeImmediate) {
-            NativeCodePush.restartAppInternal(rollbackTimeout);
+            NativeCodePush.restartImmedidateUpdate(rollbackTimeout);
+          } else {
+            this.restart = function () {
+              NaviteCodePush.restartForPendingUpdate();
+            }
           }
         });
     }