Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Commit 8539694

Browse files
committed
Merge pull request #63 from Microsoft/function_name
Removing 'Name' suffix
2 parents 46cdaf8 + c254603 commit 8539694

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

CodePush.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@
44

55
+ (NSURL *)bundleURL;
66

7-
+ (NSURL *)bundleURLForResourceName:(NSString *)resourceName;
7+
+ (NSURL *)bundleURLForResource:(NSString *)resourceName;
88

9-
+ (NSURL *)bundleURLForResourceName:(NSString *)resourceName
10-
withExtension:(NSString *)resourceExtension;
9+
+ (NSURL *)bundleURLForResource:(NSString *)resourceName
10+
withExtension:(NSString *)resourceExtension;
1111

1212
+ (NSString *)getDocumentsDirectory;
1313

CodePush.m

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,17 +27,17 @@ @implementation CodePush {
2727

2828
+ (NSURL *)bundleURL
2929
{
30-
return [self bundleURLForResourceName:@"main"];
30+
return [self bundleURLForResource:@"main"];
3131
}
3232

33-
+ (NSURL *)bundleURLForResourceName:(NSString *)resourceName
33+
+ (NSURL *)bundleURLForResource:(NSString *)resourceName
3434
{
35-
return [self bundleURLForResourceName:resourceName
36-
withExtension:@"jsbundle"];
35+
return [self bundleURLForResource:resourceName
36+
withExtension:@"jsbundle"];
3737
}
3838

39-
+ (NSURL *)bundleURLForResourceName:(NSString *)resourceName
40-
withExtension:(NSString *)resourceExtension
39+
+ (NSURL *)bundleURLForResource:(NSString *)resourceName
40+
withExtension:(NSString *)resourceExtension
4141
{
4242
NSError *error;
4343
NSString *packageFile = [CodePushPackage getCurrentPackageBundlePath:&error];
@@ -362,4 +362,4 @@ - (void)startRollbackTimer:(int)rollbackTimeout
362362
usingTestFolder = shouldUseTestFolder;
363363
}
364364

365-
@end
365+
@end

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ Once your Xcode project has been setup to build/link the CodePush plugin, you ne
7474
7575
This change configures your app to always load the most recent version of your app's JS bundle. On the initial launch, this will correspond to the file that was compiled with the app. However, after an update has been pushed via CodePush, this will return the location of the most recently installed update.
7676
77-
*NOTE: The `bundleURL` method assumes your app's JS bundle is named `main.jsbundle`. If you have configured your app to use a different file name, simply call the `bundleURLForResourceName:` method (which assumes you're using the `.jsbundle` extension) or `bundleURLForResourceName:withExtension:` method instead, in order to overwrite that default behavior*
77+
*NOTE: The `bundleURL` method assumes your app's JS bundle is named `main.jsbundle`. If you have configured your app to use a different file name, simply call the `bundleURLForResource:` method (which assumes you're using the `.jsbundle` extension) or `bundleURLForResource:withExtension:` method instead, in order to overwrite that default behavior*
7878
7979
To let the CodePush runtime know which deployment it should query for updates against, perform the following steps:
8080

0 commit comments

Comments
 (0)