isRunningBinary

Author: geof90

CodePush.m

@@ -14,6 +14,7 @@ @implementation CodePush {
 RCT_EXPORT_MODULE()
 
 static BOOL didRollback = NO;
+static BOOL isRunningBinaryVersion = NO;
 static BOOL testConfigurationFlag = NO;
 
 // These constants represent valid deployment statuses
@@ -62,6 +63,7 @@ + (NSURL *)bundleURLForResource:(NSString *)resourceName
 
     if (error || !packageFile) {
         NSLog(logMessageFormat, binaryJsBundleUrl);
+        isRunningBinaryVersion = YES;
         return binaryJsBundleUrl;
     }
 
@@ -73,6 +75,7 @@ + (NSURL *)bundleURLForResource:(NSString *)resourceName
     NSDictionary *currentPackageMetadata = [CodePushPackage getCurrentPackage:&error];
     if (error || !currentPackageMetadata) {
         NSLog(logMessageFormat, binaryJsBundleUrl);
+        isRunningBinaryVersion = YES;
         return binaryJsBundleUrl;
     }
 
@@ -82,13 +85,15 @@ + (NSURL *)bundleURLForResource:(NSString *)resourceName
         // Return package file because it is newer than the app store binary's JS bundle
         NSURL *packageUrl = [[NSURL alloc] initFileURLWithPath:packageFile];
         NSLog(logMessageFormat, packageUrl);
+        isRunningBinaryVersion = NO;
         return packageUrl;
     } else {
 #ifndef DEBUG
         [CodePush clearUpdates];
 #endif
 
         NSLog(logMessageFormat, binaryJsBundleUrl);
+        isRunningBinaryVersion = YES;
         return binaryJsBundleUrl;
     }
 }
@@ -557,9 +562,7 @@ - (void)savePendingUpdate:(NSString *)packageHash
             }
         }
     } else {
-        NSError *error;
-        NSString *currentPackageHash = [CodePushPackage getCurrentPackageHash:&error];
-        if (error || currentPackageHash == nil) {
+        if (isRunningBinaryVersion) {
             // Check if the current appVersion has been reported. Use date as the binary identifier to
             // handle binary releases that do not modify the appVersion.
             NSURL *binaryJsBundleUrl = [CodePush bundleURL];

android/app/src/main/java/com/microsoft/codepush/react/CodePush.java

@@ -40,8 +40,9 @@
 
 public class CodePush {
 
-    private static boolean testConfigurationFlag = false;
     private static boolean didRollback = false;
+    private static boolean isRunningBinaryVersion = false;
+    private static boolean testConfigurationFlag = false;
 
     private boolean didUpdate = false;
 
@@ -143,6 +144,7 @@ public String getBundleUrl(String assetsBundleFileName) {
             if (packageFilePath == null) {
                 // There has not been any downloaded updates.
                 CodePushUtils.logBundleUrl(binaryJsBundleUrl);
+                isRunningBinaryVersion = true;
                 return binaryJsBundleUrl;
             }
 
@@ -158,6 +160,7 @@ public String getBundleUrl(String assetsBundleFileName) {
                     binaryModifiedDateDuringPackageInstall == binaryResourcesModifiedTime &&
                     (this.isUsingTestConfiguration() || this.appVersion.equals(packageAppVersion))) {
                 CodePushUtils.logBundleUrl(packageFilePath);
+                isRunningBinaryVersion = false;
                 return packageFilePath;
             } else {
                 // The binary version is newer.
@@ -167,6 +170,7 @@ public String getBundleUrl(String assetsBundleFileName) {
                 }
 
                 CodePushUtils.logBundleUrl(binaryJsBundleUrl);
+                isRunningBinaryVersion = true;
                 return binaryJsBundleUrl;
             }
         } catch (NumberFormatException e) {
@@ -488,9 +492,7 @@ public void getNewStatusReport(Promise promise) {
                     }
                 }
             } else {
-                String currentPackageHash = null;
-                currentPackageHash = codePushPackage.getCurrentPackageHash();
-                if (currentPackageHash == null) {
+                if (isRunningBinaryVersion) {
                     // Check if the current appVersion has been reported.
                     String binaryIdentifier = "" + getBinaryResourcesModifiedTime();
                     if (isDeploymentStatusNotYetReported(binaryIdentifier)) {