Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Commit 89d5c14

Browse files
committed
feedback
1 parent 45c4e74 commit 89d5c14

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

CodePush.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -59,13 +59,13 @@ async function checkForUpdate(deploymentKey = null) {
5959
if (!update || update.updateAppVersion || (update.packageHash === localPackage.packageHash)) {
6060
return null;
6161
} else {
62-
let remotePackage = { ...update, ...PackageMixins.remote };
62+
const remotePackage = { ...update, ...PackageMixins.remote };
6363
remotePackage.failedInstall = await NativeCodePush.isFailedUpdate(remotePackage.packageHash);
6464
return remotePackage;
6565
}
6666
}
6767

68-
let getConfiguration = (() => {
68+
const getConfiguration = (() => {
6969
let config;
7070
return async function getConfiguration() {
7171
if (config) {
@@ -80,15 +80,15 @@ let getConfiguration = (() => {
8080
})();
8181

8282
async function getCurrentPackage() {
83-
let localPackage = await NativeCodePush.getCurrentPackage();
83+
const localPackage = await NativeCodePush.getCurrentPackage();
8484
localPackage.failedInstall = await NativeCodePush.isFailedUpdate(localPackage.packageHash);
8585
localPackage.isFirstRun = await NativeCodePush.isFirstRun(localPackage.packageHash);
8686
return localPackage;
8787
}
8888

8989
function getPromisifiedSdk(requestFetchAdapter, config) {
9090
// Use dynamically overridden AcquisitionSdk during tests.
91-
let sdk = new module.exports.AcquisitionSdk(requestFetchAdapter, config);
91+
const sdk = new module.exports.AcquisitionSdk(requestFetchAdapter, config);
9292
sdk.queryUpdateWithCurrentPackage = (queryPackage) => {
9393
return new Promise((resolve, reject) => {
9494
module.exports.AcquisitionSdk.prototype.queryUpdateWithCurrentPackage.call(sdk, queryPackage, (err, update) => {
@@ -128,7 +128,7 @@ function setUpTestDependencies(testSdk, providedTestConfig, testNativeBridge) {
128128
* when an update is available.
129129
*/
130130
async function sync(options = {}, syncStatusChangeCallback, downloadProgressCallback) {
131-
let syncOptions = {
131+
const syncOptions = {
132132

133133
deploymentKey: null,
134134
ignoreFailedUpdates: true,
@@ -191,7 +191,7 @@ async function sync(options = {}, syncStatusChangeCallback, downloadProgressCall
191191

192192
const doDownloadAndInstall = async () => {
193193
syncStatusChangeCallback(CodePush.SyncStatus.DOWNLOADING_PACKAGE);
194-
let localPackage = await remotePackage.download(downloadProgressCallback);
194+
const localPackage = await remotePackage.download(downloadProgressCallback);
195195

196196
syncStatusChangeCallback(CodePush.SyncStatus.INSTALLING_UPDATE);
197197
await localPackage.install(syncOptions.installMode, () => {
@@ -215,7 +215,7 @@ async function sync(options = {}, syncStatusChangeCallback, downloadProgressCall
215215

216216
return await new Promise((resolve, reject) => {
217217
let message = null;
218-
let dialogButtons = [{
218+
const dialogButtons = [{
219219
text: null,
220220
onPress: async () => {
221221
resolve(await doDownloadAndInstall());

package-mixins.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
"use strict";
2+
13
import { DeviceEventEmitter } from "react-native";
24

35
// This function is used to augment remote and local
@@ -34,7 +36,7 @@ export default (NativeCodePush) => {
3436

3537
const local = {
3638
async install(installMode = NativeCodePush.codePushInstallModeOnNextRestart, updateInstalledCallback) {
37-
let localPackage = this;
39+
const localPackage = this;
3840
await NativeCodePush.installUpdate(this, installMode);
3941
updateInstalledCallback && updateInstalledCallback();
4042
if (installMode == NativeCodePush.codePushInstallModeImmediate) {

0 commit comments

Comments
 (0)