Fix unnecessary asking of android deployment key with link command (#1538)

Author: alexandergoncharov-zz

package.json

@@ -41,20 +41,13 @@
   },
   "rnpm": {
     "android": {
-      "packageInstance": "new CodePush(${androidDeploymentKey}, getApplicationContext(), BuildConfig.DEBUG)"
+      "packageInstance": "new CodePush(getResources().getString(R.string.reactNativeCodePush_androidDeploymentKey), getApplicationContext(), BuildConfig.DEBUG)"
     },
     "ios": {
       "sharedLibraries": [
         "libz"
       ]
     },
-    "params": [
-      {
-        "type": "input",
-        "name": "androidDeploymentKey",
-        "message": "What is your CodePush deployment key for Android (hit <ENTER> to ignore)"
-      }
-    ],
     "commands": {
       "postlink": "node node_modules/react-native-code-push/scripts/postlink/run"
     }

scripts/postlink/android/postlink.js

@@ -1,6 +1,7 @@
 var fs = require("fs");
 var glob = require("glob");
 var path = require("path");
+var inquirer = require('inquirer');
 
 module.exports = () => {
 
@@ -91,5 +92,29 @@ module.exports = () => {
         fs.writeFileSync(buildGradlePath, buildGradleContents);
     }
 
+    //3. Add deployment key
+    var stringsResourcesPath = glob.sync("**/strings.xml", ignoreFolders)[0];
+    if (!stringsResourcesPath) {
+        return Promise.reject(new Error(`Couldn't find strings.xml. You might need to update it manually.`));
+    } else {
+        var stringsResourcesContent = fs.readFileSync(stringsResourcesPath, "utf8");
+        var deploymentKeyName = "reactNativeCodePush_androidDeploymentKey";
+        if (~stringsResourcesContent.indexOf(deploymentKeyName)) {
+            console.log(`${deploymentKeyName} already specified in the strings.xml`);
+        } else {
+            return inquirer.prompt({
+                "type": "input",
+                "name": "androidDeploymentKey",
+                "message": "What is your CodePush deployment key for Android (hit <ENTER> to ignore)"
+            }).then(function(answer) {
+                var insertAfterString = "<resources>";
+                var deploymentKeyString = `\t<string moduleConfig="true" name="${deploymentKeyName}">${answer.androidDeploymentKey || "deployment-key-here"}</string>`;
+                stringsResourcesContent = stringsResourcesContent.replace(insertAfterString,`${insertAfterString}\n${deploymentKeyString}`);
+                fs.writeFileSync(stringsResourcesPath, stringsResourcesContent);
+                return Promise.resolve();
+            });
+        }
+    }
+
     return Promise.resolve();
-}
+}

scripts/postlink/run.js

@@ -1,6 +1,6 @@
 var postlinks = [
-    require("./ios/postlink"),
-    require("./android/postlink")
+    require("./android/postlink"),
+    require("./ios/postlink")
 ];
 
 //run them sequentially