feedback

geof90 · geof90 · commit a981a763ee90 · 2015-12-23T22:54:51.000-08:00
diff --git a/CodePush.js b/CodePush.js
@@ -209,7 +209,7 @@ async function sync(options = {}, syncStatusChangeCallback, downloadProgressCall
       if (typeof syncOptions.updateDialog !== "object") {
         syncOptions.updateDialog = CodePush.DEFAULT_UPDATE_DIALOG;
       } else {
-        syncOptions.updateDialog = Object.assign({}, CodePush.DEFAULT_UPDATE_DIALOG, syncOptions.updateDialog);
+        syncOptions.updateDialog = { ...CodePush.DEFAULT_UPDATE_DIALOG, ...syncOptions.updateDialog };
       }
         
       return await new Promise((resolve, reject) => {  

Original file line number	Diff line number	Diff line change
`@@ -209,7 +209,7 @@ async function sync(options = {}, syncStatusChangeCallback, downloadProgressCall`
`209`	`209`	`if (typeof syncOptions.updateDialog !== "object") {`
`210`	`210`	`syncOptions.updateDialog = CodePush.DEFAULT_UPDATE_DIALOG;`
`211`	`211`	`} else {`
`212`		`- syncOptions.updateDialog = Object.assign({}, CodePush.DEFAULT_UPDATE_DIALOG, syncOptions.updateDialog);`
	`212`	`+ syncOptions.updateDialog = { ...CodePush.DEFAULT_UPDATE_DIALOG, ...syncOptions.updateDialog };`
`213`	`213`	`}`
`214`	`214`
`215`	`215`	`return await new Promise((resolve, reject) => {`