Skip to content
This repository was archived by the owner on May 20, 2025. It is now read-only.

Commit dfe154d

Browse files
ptomasroossergey-akhalkov
authored andcommitted
Remove overriden createJSModules (#895)
Since of recently in master the unused createJSModules has been removed and ReactPackage's no longer contain the definition of createJSModules. There for it must be removed in order to not yield a compile error. This is breaking change. facebook/react-native@ce6fb33
1 parent 44e5c84 commit dfe154d

File tree

1 file changed

+0
-5
lines changed
  • android/app/src/main/java/com/microsoft/codepush/react

1 file changed

+0
-5
lines changed

android/app/src/main/java/com/microsoft/codepush/react/CodePush.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -302,11 +302,6 @@ public List<NativeModule> createNativeModules(ReactApplicationContext reactAppli
302302
return nativeModules;
303303
}
304304

305-
@Override
306-
public List<Class<? extends JavaScriptModule>> createJSModules() {
307-
return new ArrayList<>();
308-
}
309-
310305
@Override
311306
public List<ViewManager> createViewManagers(ReactApplicationContext reactApplicationContext) {
312307
return new ArrayList<>();

0 commit comments

Comments
 (0)