Commit 11ab6cd
[fabric] Use wrapped text view for multiline TextInput
Summary:
This diff updates the core TextInput RN component to use the wrapped text view for multiline TextInput.
Switching to `RCTWrappedTextView` enables correct `borderWidth` and `contentInsets` support for multi line text inputs while maintaining the same functionality for single line text input.
Scrolling text views are also supported correctly, with vertical height dependent scrollers.
Test Plan:
- Build Zeratul with Fabric enabled.
- Type in the search field to test the layout of the text contents
- Type in the composer to test multi line support and the layout of the text contents
| Before | After |
|--|
| https://pxl.cl/3Xrrx | https://pxl.cl/3Xrr9 |
Reviewers: shawndempsey, #rn-desktop
Reviewed By: shawndempsey
Differential Revision: https://phabricator.intern.facebook.com/D51962396
Tasks: T167538822, T1578895911 parent c7ecd3c commit 11ab6cd
File tree
1 file changed
+9
-2
lines changed- packages/react-native/React/Fabric/Mounting/ComponentViews/TextInput
1 file changed
+9
-2
lines changedLines changed: 9 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
19 | 22 | | |
20 | 23 | | |
21 | 24 | | |
| |||
86 | 89 | | |
87 | 90 | | |
88 | 91 | | |
| 92 | + | |
89 | 93 | | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
90 | 97 | | |
91 | 98 | | |
92 | 99 | | |
| |||
672 | 679 | | |
673 | 680 | | |
674 | 681 | | |
675 | | - | |
| 682 | + | |
676 | 683 | | |
677 | 684 | | |
678 | 685 | | |
| |||
967 | 974 | | |
968 | 975 | | |
969 | 976 | | |
970 | | - | |
| 977 | + | |
971 | 978 | | |
972 | 979 | | |
973 | 980 | | |
| |||
0 commit comments