Apply suggestions from code review

Co-authored-by: Tommy Nguyen <[email protected]>

Author: Saadnajmi

packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm

@@ -1716,7 +1716,7 @@ - (void)buildDataTransferItems:(std::vector<DataTransferItem> &)dataTransferItem
   for (NSString *file in fileNames) {
     NSURL *fileURL = [NSURL fileURLWithPath:file];
     BOOL isDir = NO;
-    BOOL isValid = (![[NSFileManager defaultManager] fileExistsAtPath:fileURL.path isDirectory:&isDir] || isDir) ? NO : YES;
+    BOOL isValid = [[NSFileManager defaultManager] fileExistsAtPath:fileURL.path isDirectory:&isDir] && !isDir;
     if (isValid) {
 
       NSString *MIMETypeString = nil;
@@ -1736,14 +1736,6 @@ - (void)buildDataTransferItems:(std::vector<DataTransferItem> &)dataTransferItem
                                         forKey:NSURLFileSizeKey
                                          error:&fileSizeError];
 
-      NSNumber *width = nil;
-      NSNumber *height = nil;
-      if ([MIMETypeString hasPrefix:@"image/"]) {
-        NSImage *image = [[NSImage alloc] initWithContentsOfURL:fileURL];
-        width = @(image.size.width);
-        height = @(image.size.height);
-      }
-
       DataTransferItem transferItem = {
         .name = fileURL.lastPathComponent.UTF8String,
         .kind = "file",
@@ -1755,12 +1747,10 @@ - (void)buildDataTransferItems:(std::vector<DataTransferItem> &)dataTransferItem
         transferItem.size = fileSizeValue.intValue;
       }
 
-      if (width != nil) {
-        transferItem.width = width.intValue;
-      }
-      
-      if (height != nil) {
-        transferItem.height = height.intValue;
+      if ([MIMETypeString hasPrefix:@"image/"]) {
+        NSImage *image = [[NSImage alloc] initWithContentsOfURL:fileURL];
+        transferItem.width = static_cast<int>(image.size.width);
+        transferItem.height = static_cast<int>(image.size.height);
       }
 
       dataTransferItems.push_back(transferItem);
@@ -1777,9 +1767,9 @@ - (void)buildDataTransferItems:(std::vector<DataTransferItem> &)dataTransferItem
       .kind = "image",
       .type = MIMETypeString.UTF8String,
       .uri = RCTDataURL(MIMETypeString, imageData).absoluteString.UTF8String,
-      .size = imageData.length,
-      .width = image.size.width,
-      .height = image.size.height,
+      .size = static_cast<int>(imageData.length),
+      .width = static_cast<int>(image.size.width),
+      .height = static_cast<int>(image.size.height),
     };
 
     dataTransferItems.push_back(transferItem);

packages/react-native/ReactCommon/react/renderer/components/view/platform/macos/react/renderer/components/view/HostPlatformViewProps.cpp

@@ -70,11 +70,11 @@ HostPlatformViewProps::HostPlatformViewProps(
           ReactNativeFeatureFlags::enableCppPropsIteratorSetter()
               ? sourceProps.draggedTypes
               : convertRawProp(
-                context,
-                rawProps,
-                "draggedTypes",
-                sourceProps.draggedTypes,
-                {}))
+                  context,
+                  rawProps,
+                  "draggedTypes",
+                  sourceProps.draggedTypes,
+                {})),
       tooltip(
         ReactNativeFeatureFlags::enableCppPropsIteratorSetter()
             ? sourceProps.tooltip