bugfix: Only handle first javascript fatal error (facebook#47914)

RSNara · facebook-github-bot · commit 1fed2cfdef70 · 2024-11-22T18:10:23.000-08:00
Summary: Pull Request resolved: facebook#47914 This was a bug in the original diff: D66193194. If a fatal js error happens, we should only drop subsequent **fatal** js errors. It's fine to report soft errors. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D66392706 fbshipit-source-id: c51bae186184c54faa9bce065b81b442607e751b
diff --git a/packages/react-native/ReactCommon/jserrorhandler/JsErrorHandler.cpp b/packages/react-native/ReactCommon/jserrorhandler/JsErrorHandler.cpp
@@ -379,11 +379,14 @@ void JsErrorHandler::handleErrorWithCppPipeline(
     }
   }
 
-  if (*shouldPreventDefault || _hasHandledFatalError) {
+  if (*shouldPreventDefault) {
     return;
   }
 
   if (isFatal) {
+    if (_hasHandledFatalError) {
+      return;
+    }
     _hasHandledFatalError = true;
   }
 

Original file line number	Diff line number	Diff line change
`@@ -379,11 +379,14 @@ void JsErrorHandler::handleErrorWithCppPipeline(`
`379`	`379`	`}`
`380`	`380`	`}`
`381`	`381`
`382`		`- if (*shouldPreventDefault \|\| _hasHandledFatalError) {`
	`382`	`+ if (*shouldPreventDefault) {`
`383`	`383`	`return;`
`384`	`384`	`}`
`385`	`385`
`386`	`386`	`if (isFatal) {`
	`387`	`+ if (_hasHandledFatalError) {`
	`388`	`+ return;`
	`389`	`+ }`
`387`	`390`	`_hasHandledFatalError = true;`
`388`	`391`	`}`
`389`	`392`