fix(react-native): implement projectConfig and dependencyConfig (#2231)

Author: tido64

packages/react-native/local-cli/runMacOS/findXcodeProject.js

@@ -1,8 +1,8 @@
+// @ts-check
 /**
  * Copyright (c) Microsoft Corporation. All rights reserved.
  * Licensed under the MIT License.
  * @format
- * @ts-check
  */
 'use strict';
 
@@ -20,14 +20,22 @@
  *
  * @typedef {{
  *   name: string;
+ *   path: string;
  *   isWorkspace: boolean;
  * }} XcodeProject
+ *
+ * @typedef {{
+ *   project?: {
+ *     macos?: {
+ *       sourceDir: string;
+ *       xcodeProject: XcodeProject;
+ *     }
+ *   }
+ * }} ProjectConfig
  */
 
-const findXcodeProject = require('./findXcodeProject');
 const chalk = require('chalk');
 const child_process = require('child_process');
-const fs = require('fs');
 const path = require('path');
 const {logger, CLIError, getDefaultUserTerminal} = (() => {
   const cli = require.resolve('@react-native-community/cli/package.json');
@@ -37,16 +45,11 @@ const {logger, CLIError, getDefaultUserTerminal} = (() => {
 })();
 
 /**
+ * @param {ProjectConfig} ctx
  * @param {Options} args
- * @returns {{ xcodeProject: XcodeProject, scheme: string }}
+ * @returns {{ sourceDir: string, xcodeProject: XcodeProject, scheme: string }}
  */
-function parseArgs(args) {
-  if (!fs.existsSync(args.projectPath)) {
-    throw new CLIError(
-      'macOS project folder not found. Are you sure this is a React Native project?',
-    );
-  }
-
+function parseArgs(ctx, args) {
   if (args.configuration) {
     logger.warn(
       'Argument --configuration has been deprecated and will be removed in a future release, please use --mode instead.',
@@ -57,15 +60,20 @@ function parseArgs(args) {
     }
   }
 
-  process.chdir(args.projectPath);
+  const {sourceDir, xcodeProject} = ctx.project?.macos ?? {};
+  if (!sourceDir) {
+    throw new CLIError(
+      'macOS project folder not found. Are you sure this is a React Native project?',
+    );
+  }
 
-  const xcodeProject = findXcodeProject(fs.readdirSync('.'));
   if (!xcodeProject) {
     throw new CLIError(
-      `Could not find Xcode project files in "${args.projectPath}" folder`,
+      'Xcode project for macOS not found. Did you forget to run `pod install`?',
     );
   }
 
+  // TODO: Find schemes using https://github.com/microsoft/rnx-kit/blob/2b4c569cda9e3755ba7afce42d846601bcc7c4e3/packages/tools-apple/src/scheme.ts#L5
   const inferredSchemeName =
     path.basename(xcodeProject.name, path.extname(xcodeProject.name)) +
     '-macOS';
@@ -77,36 +85,37 @@ function parseArgs(args) {
     } "${chalk.bold(xcodeProject.name)}"`,
   );
 
-  return {xcodeProject, scheme};
+  return {sourceDir, xcodeProject, scheme};
 }
 
 /**
  * @param {string[]} _
- * @param {Record<string, unknown>} _ctx
+ * @param {ProjectConfig} ctx
  * @param {Options} args
  */
-function buildMacOS(_, _ctx, args) {
-  const {xcodeProject, scheme} = parseArgs(args);
-  return buildProject(xcodeProject, scheme, {...args, packager: false});
+function buildMacOS(_, ctx, args) {
+  const {sourceDir, xcodeProject, scheme} = parseArgs(ctx, args);
+  return buildProject(sourceDir, xcodeProject, scheme, {...args, packager: false});
 }
 
 /**
  * @param {string[]} _
- * @param {Record<string, unknown>} _ctx
+ * @param {ProjectConfig} ctx
  * @param {Options} args
  */
-function runMacOS(_, _ctx, args) {
-  const {xcodeProject, scheme} = parseArgs(args);
-  return run(xcodeProject, scheme, args);
+function runMacOS(_, ctx, args) {
+  const {sourceDir, xcodeProject, scheme} = parseArgs(ctx, args);
+  return run(sourceDir, xcodeProject, scheme, args);
 }
 
 /**
+ * @param {string} sourceDir
  * @param {XcodeProject} xcodeProject
  * @param {string} scheme
  * @param {Options} args
  */
-async function run(xcodeProject, scheme, args) {
-  await buildProject(xcodeProject, scheme, args);
+async function run(sourceDir, xcodeProject, scheme, args) {
+  await buildProject(sourceDir, xcodeProject, scheme, args);
 
   const buildSettings = getBuildSettings(xcodeProject, args.mode, scheme);
   const appPath = path.join(
@@ -143,15 +152,17 @@ async function run(xcodeProject, scheme, args) {
 }
 
 /**
+ * @param {string} sourceDir
  * @param {XcodeProject} xcodeProject
  * @param {string} scheme
  * @param {Options} args
+ * @returns {Promise<void>}
  */
-function buildProject(xcodeProject, scheme, args) {
+function buildProject(sourceDir, xcodeProject, scheme, args) {
   return new Promise((resolve, reject) => {
     const xcodebuildArgs = [
       xcodeProject.isWorkspace ? '-workspace' : '-project',
-      xcodeProject.name,
+      path.join(sourceDir, xcodeProject.path, xcodeProject.name),
       '-configuration',
       args.mode,
       '-scheme',

packages/react-native/local-cli/runMacOS/runMacOS.js

@@ -113,6 +113,7 @@
     "@jest/create-cache-key-function": "^29.6.3",
     "@react-native-community/cli": "14.0.0-alpha.2",
     "@react-native-community/cli-platform-android": "14.0.0-alpha.2",
+    "@react-native-community/cli-platform-apple": "14.0.0-alpha.2",
     "@react-native-community/cli-platform-ios": "14.0.0-alpha.2",
     "@react-native-mac/virtualized-lists": "0.75.0-main",
     "@react-native/assets-registry": "0.75.0-main",

packages/react-native/package.json

@@ -43,6 +43,10 @@ try {
 }
 
 const macosCommands = require('./local-cli/runMacOS/runMacOS'); // [macOS]
+const {
+  getDependencyConfig,
+  getProjectConfig,
+} = require('@react-native-community/cli-platform-apple'); // [macOS]
 const {
   bundleCommand,
   startCommand,
@@ -128,8 +132,8 @@ config.platforms.macos = {
       ) => {},
     };
   },
-  projectConfig: () => null,
-  dependencyConfig: () => null,
+  projectConfig: getProjectConfig({platformName: 'macos'}),
+  dependencyConfig: getDependencyConfig({platformName: 'macos'}),
   npmPackageName: 'react-native-macos',
 };
 // macOS]

packages/react-native/react-native.config.js

@@ -12937,6 +12937,7 @@ __metadata:
     "@jest/create-cache-key-function": "npm:^29.6.3"
     "@react-native-community/cli": "npm:14.0.0-alpha.2"
     "@react-native-community/cli-platform-android": "npm:14.0.0-alpha.2"
+    "@react-native-community/cli-platform-apple": "npm:14.0.0-alpha.2"
     "@react-native-community/cli-platform-ios": "npm:14.0.0-alpha.2"
     "@react-native-mac/virtualized-lists": "npm:0.75.0-main"
     "@react-native/assets-registry": "npm:0.75.0-main"
@@ -14651,11 +14652,11 @@ __metadata:
 
 "typescript@patch:typescript@npm%3A^5.6.3#optional!builtin<compat/typescript>":
   version: 5.6.3
-  resolution: "typescript@patch:typescript@npm%3A5.6.3#optional!builtin<compat/typescript>::version=5.6.3&hash=379a07"
+  resolution: "typescript@patch:typescript@npm%3A5.6.3#optional!builtin<compat/typescript>::version=5.6.3&hash=8c6c40"
   bin:
     tsc: bin/tsc
     tsserver: bin/tsserver
-  checksum: 10c0/ac8307bb06bbfd08ae7137da740769b7d8c3ee5943188743bb622c621f8ad61d244767480f90fbd840277fbf152d8932aa20c33f867dea1bb5e79b187ca1a92f
+  checksum: 10c0/7c9d2e07c81226d60435939618c91ec2ff0b75fbfa106eec3430f0fcf93a584bc6c73176676f532d78c3594fe28a54b36eb40b3d75593071a7ec91301533ace7
   languageName: node
   linkType: hard