Skip to content

Commit 39c1dfe

Browse files
committed
use Boolean more
1 parent 06fe614 commit 39c1dfe

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

packages/react-native/Libraries/Components/TextInput/TextInput.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1676,10 +1676,10 @@ function InternalTextInput(props: TextInputProps): React.Node {
16761676
const isHandled = props.keyDownEvents.some(({key, metaKey, ctrlKey, altKey, shiftKey}: HandledKeyEvent) => {
16771677
return (
16781678
event.nativeEvent.key === key &&
1679-
(metaKey ?? false) === event.nativeEvent.metaKey &&
1680-
(ctrlKey ?? false) === event.nativeEvent.ctrlKey &&
1681-
(altKey ?? false) === event.nativeEvent.altKey &&
1682-
(shiftKey ?? false) === event.nativeEvent.shiftKey
1679+
Boolean(metaKey) === event.nativeEvent.metaKey &&
1680+
Boolean(ctrlKey) === event.nativeEvent.ctrlKey &&
1681+
Boolean(altKey) === event.nativeEvent.altKey &&
1682+
Boolean(shiftKey) === event.nativeEvent.shiftKey
16831683
);
16841684
});
16851685
if (isHandled) {
@@ -1694,10 +1694,10 @@ function InternalTextInput(props: TextInputProps): React.Node {
16941694
const isHandled = props.keyUpEvents.some(({key, metaKey, ctrlKey, altKey, shiftKey}: HandledKeyEvent) => {
16951695
return (
16961696
event.nativeEvent.key === key &&
1697-
(metaKey ?? false) === event.nativeEvent.metaKey &&
1698-
(ctrlKey ?? false) === event.nativeEvent.ctrlKey &&
1699-
(altKey ?? false) === event.nativeEvent.altKey &&
1700-
(shiftKey ?? false) === event.nativeEvent.shiftKey
1697+
Boolean(metaKey) === event.nativeEvent.metaKey &&
1698+
Boolean(ctrlKey) === event.nativeEvent.ctrlKey &&
1699+
Boolean(altKey) === event.nativeEvent.altKey &&
1700+
Boolean(shiftKey) === event.nativeEvent.shiftKey
17011701
);
17021702
});
17031703
if (isHandled) {

packages/react-native/Libraries/Components/View/View.js

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -101,10 +101,10 @@ const View: component(
101101
const isHandled = otherProps.keyDownEvents.some(({key, metaKey, ctrlKey, altKey, shiftKey}: HandledKeyEvent) => {
102102
return (
103103
event.nativeEvent.key === key &&
104-
(metaKey ?? false) === event.nativeEvent.metaKey &&
105-
(ctrlKey ?? false) === event.nativeEvent.ctrlKey &&
106-
(altKey ?? false) === event.nativeEvent.altKey &&
107-
(shiftKey ?? false) === event.nativeEvent.shiftKey
104+
Boolean(metaKey) === event.nativeEvent.metaKey &&
105+
Boolean(ctrlKey) === event.nativeEvent.ctrlKey &&
106+
Boolean(altKey) === event.nativeEvent.altKey &&
107+
Boolean(shiftKey) === event.nativeEvent.shiftKey
108108
);
109109
});
110110
if (isHandled) {
@@ -119,10 +119,10 @@ const View: component(
119119
const isHandled = otherProps.keyUpEvents.some(({key, metaKey, ctrlKey, altKey, shiftKey}: HandledKeyEvent) => {
120120
return (
121121
event.nativeEvent.key === key &&
122-
(metaKey ?? false) === event.nativeEvent.metaKey &&
123-
(ctrlKey ?? false) === event.nativeEvent.ctrlKey &&
124-
(altKey ?? false) === event.nativeEvent.altKey &&
125-
(shiftKey ?? false) === event.nativeEvent.shiftKey
122+
Boolean(metaKey) === event.nativeEvent.metaKey &&
123+
Boolean(ctrlKey) === event.nativeEvent.ctrlKey &&
124+
Boolean(altKey) === event.nativeEvent.altKey &&
125+
Boolean(shiftKey) === event.nativeEvent.shiftKey
126126
);
127127
});
128128
if (isHandled) {

0 commit comments

Comments
 (0)