Skip to content

Commit 3ba1936

Browse files
authored
chore: remove RCTAddressSanitizerCrashManager (#2395)
## Summary: This module is flagged internally by our static analysis. This module and test was added to test that ASAN was actually enabled and would crash on unsafe code. This meant checking in unsafe code as a test, which is now flagged now that we build from source internally. We don't need this module and test anymore, and we never had any automated tests that actually checked that this crashes. Let's just delete it. ## Test Plan: CI should pass.
1 parent 104e9f8 commit 3ba1936

File tree

7 files changed

+0
-115
lines changed

7 files changed

+0
-115
lines changed

packages/react-native/Libraries/AddressSanitizerCrash/AddressSanitizerCrash.js

Lines changed: 0 additions & 13 deletions
This file was deleted.

packages/react-native/Libraries/AddressSanitizerCrash/NativeAddressSanitizerCrash.js

Lines changed: 0 additions & 19 deletions
This file was deleted.

packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -35,17 +35,6 @@ declare export default typeof NativeActionSheetManager;
3535
"
3636
`;
3737

38-
exports[`public API should not change unintentionally Libraries/AddressSanitizerCrash/AddressSanitizerCrash.js 1`] = `
39-
"declare module.exports: NativeAddressSanitizerCrash;
40-
"
41-
`;
42-
43-
exports[`public API should not change unintentionally Libraries/AddressSanitizerCrash/NativeAddressSanitizerCrash.js 1`] = `
44-
"export interface Spec extends TurboModule {}
45-
declare export default ?Spec;
46-
"
47-
`;
48-
4938
exports[`public API should not change unintentionally Libraries/Alert/Alert.js 1`] = `
5039
"export type AlertType =
5140
| \\"default\\"

packages/react-native/React/CoreModules/RCTAddressSanitizerCrashManager.h

Lines changed: 0 additions & 12 deletions
This file was deleted.

packages/react-native/React/CoreModules/RCTAddressSanitizerCrashManager.mm

Lines changed: 0 additions & 18 deletions
This file was deleted.

packages/rn-tester/js/examples/ASAN/ASANCrashExample.js

Lines changed: 0 additions & 38 deletions
This file was deleted.

packages/rn-tester/js/utils/RNTesterList.ios.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -371,10 +371,6 @@ const APIs: Array<RNTesterModuleInfo> = ([
371371
module: require('../examples/Performance/PerformanceApiExample'),
372372
},
373373
// [macOS
374-
{
375-
key: 'ASANCrashExample',
376-
module: require('../examples/ASAN/ASANCrashExample'),
377-
},
378374
{
379375
key: 'Focus Ring',
380376
module: require('../examples/FocusRing/FocusRingExample'),

0 commit comments

Comments
 (0)