Skip to content

Commit 4901952

Browse files
authored
Merge pull request #1931 from amgleitman/0.72-ready-for-release
Mark 0.72 as ready for release
2 parents dfae96c + eb3a552 commit 4901952

File tree

4 files changed

+215
-205
lines changed

4 files changed

+215
-205
lines changed

.ado/get-next-semver-version.js

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,14 @@ function getNextVersion(patchVersionPrefix) {
1010

1111
const prerelease = semver.prerelease(releaseVersion);
1212

13-
if (!prerelease) {
13+
if (!prerelease || prerelease[0] === 'ready') {
1414
if (patchVersionPrefix) {
1515
releaseVersion = semver.inc(releaseVersion, 'prerelease', patchVersionPrefix);
1616
}
1717
else {
18-
releaseVersion = semver.inc(releaseVersion, 'patch');
18+
releaseVersion = semver.inc(releaseVersion, 'patch');
1919
}
20-
}
21-
22-
if (prerelease) {
20+
} else {
2321
releaseVersion = semver.inc(releaseVersion, 'prerelease');
2422
if (patchVersionPrefix) {
2523
releaseVersion = releaseVersion.replace(`-${prerelease[0]}.`, `-${prerelease[0]}-${patchVersionPrefix}.`);

docs/Releases.md

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,5 +69,17 @@ The Publish flow does the following:
6969
3. Call `prepare-package-for-release` to bump versions, tag the commit, and push to git
7070
4. Call `publish-npm` to publish to NPM the version that was just tagged.
7171
4. Generate the correct NPM `dist-tag` and publish to NPM
72-
5. Commit all changed files and push back to Github
72+
5. Commit all changed files and push back to Github
7373

74+
### Publishing New Versions
75+
76+
Each minor version publishes out of its own branch (e.g., 0.71-stable for react-native-macos 0.71.x). In order to ensure initial releases are properly versioned, we have a special prerelease name called `ready`. This will tell our `get-next-semver-version` script that we're ready to release the next version.
77+
78+
We do this so that our first release will have a proper patch version of 0, as shown by this snippet from an interactive Node.js console:
79+
80+
```js
81+
> semver.inc('0.72.0', 'patch')
82+
'0.72.1' // Not ideal
83+
> semver.inc('0.72.0-ready', 'patch')
84+
'0.72.0' // Better!
85+
```

packages/react-native/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-native-macos",
3-
"version": "0.72.0-0",
3+
"version": "0.72.0-ready",
44
"bin": "./cli.js",
55
"description": "React Native for macOS",
66
"license": "MIT",

0 commit comments

Comments
 (0)