Skip to content

Commit 4d057af

Browse files
authored
Revert an RTL change we made that FB fixed at a lower level, making this obsolete. This file now aligns with what FB has in their repo (#194)
1 parent 5302400 commit 4d057af

File tree

1 file changed

+4
-17
lines changed

1 file changed

+4
-17
lines changed

React/Views/SafeAreaView/RCTSafeAreaShadowView.m

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
#import <yoga/Yoga.h>
1212

1313
#import "RCTSafeAreaViewLocalData.h"
14-
#import "RCTI18nUtil.h"
1514

1615
@implementation RCTSafeAreaShadowView
1716

@@ -22,24 +21,12 @@ - (void)setLocalData:(RCTSafeAreaViewLocalData *)localData
2221

2322
UIEdgeInsets insets = localData.insets;
2423

24+
super.paddingLeft = (YGValue){insets.left, YGUnitPoint};
25+
super.paddingRight = (YGValue){insets.right, YGUnitPoint};
2526
super.paddingTop = (YGValue){insets.top, YGUnitPoint};
2627
super.paddingBottom = (YGValue){insets.bottom, YGUnitPoint};
27-
// [TODO(OSS OC#2726827)
28-
if ([[RCTI18nUtil sharedInstance] doLeftAndRightSwapInRTL]) {
29-
if ([[RCTI18nUtil sharedInstance] isRTL]) {
30-
super.paddingStart = (YGValue){insets.right, YGUnitPoint};
31-
super.paddingEnd = (YGValue){insets.left, YGUnitPoint};
32-
} else {
33-
super.paddingStart = (YGValue){insets.left, YGUnitPoint};
34-
super.paddingEnd = (YGValue){insets.right, YGUnitPoint};
35-
}
36-
[self didSetProps:@[@"paddingStart", @"paddingEnd", @"paddingTop", @"paddingBottom"]];
37-
} else {
38-
super.paddingLeft = (YGValue){insets.left, YGUnitPoint};
39-
super.paddingRight = (YGValue){insets.right, YGUnitPoint};
40-
[self didSetProps:@[@"paddingLeft", @"paddingRight", @"paddingTop", @"paddingBottom"]];
41-
}
42-
// ]TODO(OSS OC#2726827)
28+
29+
[self didSetProps:@[@"paddingLeft", @"paddingRight", @"paddingTop", @"paddingBottom"]];
4330
}
4431

4532
/**

0 commit comments

Comments
 (0)