Skip to content

Commit 7bb5df3

Browse files
authored
ci: update lock file through nx.json flag instead (#2476)
## Summary: This reverts commit 791012b. We had some custom logic to update the lock file after the "version" step of release happened. Turns out you can just do that directly through `nx`... so let's remove the logic and do it that was instead. ## Test Plan: Ran `nx release --skip-publish` locally (and cmd+c'ed it before it committed anything...) to see if the lock would update with the new versions and it did.
1 parent fd4d1fa commit 7bb5df3

File tree

2 files changed

+1
-9
lines changed

2 files changed

+1
-9
lines changed

nx.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@
2929
"currentVersionResolverMetadata": {
3030
"tag": "nightly"
3131
},
32-
"preid": "nightly",
33-
"skipLockFileUpdate": true
32+
"preid": "nightly"
3433
}
3534
}
3635
}

packages/nx-release-version/index.js

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
const { releaseVersionGenerator } = require('@nx/js/src/generators/release-version/release-version');
44
const fs = require('node:fs');
55
const path = require('node:path');
6-
const { spawnSync } = require('node:child_process');
76
const { REPO_ROOT } = require('../../scripts/consts');
87

98
/**
@@ -18,8 +17,6 @@ async function runSetVersion() {
1817

1918
await updateReactNativeArtifacts(version);
2019

21-
spawnSync('yarn', ['install', '--mode', 'update-lockfile']);
22-
2320
return [
2421
path.join(
2522
REPO_ROOT,
@@ -66,10 +63,6 @@ async function runSetVersion() {
6663
'Core',
6764
'ReactNativeVersion.js',
6865
),
69-
path.join(
70-
REPO_ROOT,
71-
'yarn.lock',
72-
),
7366
];
7467
}
7568

0 commit comments

Comments
 (0)