Skip to content

Commit 8369922

Browse files
sammy-SCfacebook-github-bot
authored andcommitted
isolate use of folly to interpolateViewProps on Android (facebook#48556)
Summary: Pull Request resolved: facebook#48556 Changelog: [Internal] the only place in view module that uses folly is `ViewPropsInterpolation.h` and that is only on Android. This diff makes that dependency explicit and make it android only. Reviewed By: javache Differential Revision: D67942951 fbshipit-source-id: 2a1a41f5a4caba553e81d4bb78ac9c84ba90b60b
1 parent 55d0bc4 commit 8369922

File tree

5 files changed

+6
-5
lines changed

5 files changed

+6
-5
lines changed

packages/react-native/ReactCommon/react/renderer/components/view/ViewPropsInterpolation.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@
1010
#include <react/renderer/components/view/ViewProps.h>
1111
#include <react/renderer/graphics/Transform.h>
1212

13+
#ifdef ANDROID
14+
#include <folly/dynamic.h>
15+
#endif
16+
1317
namespace facebook::react {
1418

1519
/**

packages/react-native/ReactCommon/react/renderer/components/view/conversions.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77

88
#pragma once
99

10-
#include <folly/Conv.h>
11-
#include <folly/dynamic.h>
1210
#include <glog/logging.h>
1311
#include <react/debug/react_native_expect.h>
1412
#include <react/renderer/components/view/primitives.h>

packages/react-native/ReactCommon/react/renderer/core/Props.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77

88
#include "Props.h"
99

10-
#include <folly/dynamic.h>
1110
#include <react/renderer/core/propsConversions.h>
1211

1312
#include <react/featureflags/ReactNativeFeatureFlags.h>

packages/react-native/ReactCommon/react/renderer/core/Props.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77

88
#pragma once
99

10-
#include <folly/dynamic.h>
11-
1210
#include <react/renderer/core/PropsMacros.h>
1311
#include <react/renderer/core/PropsParserContext.h>
1412
#include <react/renderer/core/RawProps.h>
@@ -17,6 +15,7 @@
1715
#include <react/renderer/debug/DebugStringConvertible.h>
1816

1917
#ifdef ANDROID
18+
#include <folly/dynamic.h>
2019
#include <react/renderer/mapbuffer/MapBufferBuilder.h>
2120
#endif
2221

packages/react-native/ReactCommon/react/renderer/core/RawPropsPrimitives.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
#pragma once
99

10+
#include <cstdint>
1011
#include <limits>
1112

1213
namespace facebook::react {

0 commit comments

Comments
 (0)