Skip to content

Commit 91405a2

Browse files
vzaidmangabrieldonadel
authored andcommitted
fix race condition in getPages test for device disconnection (facebook#49741)
Summary: Pull Request resolved: facebook#49741 While the test delay `PAGES_POLLING_DELAY` is usually enough to be equal to `PAGES_POLLING_INTERVAL`, in some cases we need extra time to sync that with the polling in `Devices.js`. Changelog: [General][Internal] - fix test Reviewed By: huntie Differential Revision: D70384823 fbshipit-source-id: ccb18884d32dc27636dbbb3a9786412056f90830
1 parent 5a9df37 commit 91405a2

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

packages/dev-middleware/src/__tests__/InspectorProxyHttpApi-test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ import {createDeviceMock} from './InspectorDeviceUtils';
2020
import {withAbortSignalForEachTest} from './ResourceUtils';
2121
import {withServerForEachTest} from './ServerUtils';
2222

23-
// Must be greater than or equal to PAGES_POLLING_INTERVAL in `InspectorProxy.js`.
24-
const PAGES_POLLING_DELAY = 1000;
23+
// Must be greater than PAGES_POLLING_INTERVAL in `Device.js`
24+
const PAGES_POLLING_DELAY = 2100;
2525

2626
jest.useFakeTimers();
2727

0 commit comments

Comments
 (0)