Skip to content

Commit a0d76f3

Browse files
hansenyySaadnajmi
andauthored
chore: Remove @definitelytyped/dtslint dependency (#2665)
This PR gets rid of the dependency on @definitelytyped/dtslint in order to mitigate CVE-2025-7783. We are essentially cherry-picking the following commits from facebook upstream. - facebook@2e0c2c6 - facebook@67a6380 --------- Co-authored-by: Saad Najmi <[email protected]>
1 parent 149b2d1 commit a0d76f3

File tree

3 files changed

+70
-1173
lines changed

3 files changed

+70
-1173
lines changed

package.json

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,7 @@
2929
"test-e2e-local-clean": "node ./scripts/release-testing/test-e2e-local-clean.js",
3030
"test-e2e-local": "node ./scripts/release-testing/test-e2e-local.js",
3131
"test-ios": "./scripts/objc-test.sh test",
32-
"test-typescript-offline": "dtslint --localTs node_modules/typescript/lib packages/react-native/types",
33-
"test-typescript": "dtslint packages/react-native/types",
32+
"test-typescript": "tsc -p packages/react-native/types/tsconfig.json",
3433
"test": "jest",
3534
"fantom": "JS_DIR='..' yarn jest --config packages/react-native-fantom/config/jest.config.js",
3635
"trigger-react-native-release": "node ./scripts/releases-local/trigger-react-native-release.js",
@@ -51,7 +50,6 @@
5150
"@babel/plugin-transform-regenerator": "^7.24.7",
5251
"@babel/preset-env": "^7.25.3",
5352
"@babel/preset-flow": "^7.24.7",
54-
"@definitelytyped/dtslint": "^0.0.127",
5553
"@jest/create-cache-key-function": "^29.7.0",
5654
"@nx/js": "^21.4.1",
5755
"@react-native/metro-babel-transformer": "workspace:*",

scripts/run-ci-javascript-tests.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ try {
103103
}
104104

105105
describe('Test: TypeScript tests');
106-
if (exec(`${YARN_BINARY} run test-typescript-offline`).code) {
106+
if (exec(`${YARN_BINARY} run test-typescript`).code) {
107107
echo('Failed to run TypeScript tests.');
108108
exitCode = 1;
109109
throw Error(exitCode);

0 commit comments

Comments
 (0)