confligure bundler is modal

Author: Saadnajmi

packages/react-native/React/CoreModules/RCTDevMenu.mm

@@ -433,43 +433,42 @@ - (void)setDefaultJSBundle
                       [alert addButtonWithTitle:@"Cancel"];
                       [alert setAlertStyle:NSAlertStyleWarning];
 
-                      [alert beginSheetModalForWindow:[NSApp keyWindow]
-                                    completionHandler:^(NSModalResponse response) {
-                                      if (response == NSAlertFirstButtonReturn) {
-                                        // Apply Changes
-                                        NSString *ipAddress = ipTextField.stringValue;
-                                        NSString *port = portTextField.stringValue;
-                                        NSString *bundleRoot = entrypointTextField.stringValue;
-
-                                        if (ipAddress.length == 0 && port.length == 0) {
-                                          [weakSelf setDefaultJSBundle];
-                                          return;
-                                        }
-
-                                        NSNumberFormatter *formatter = [NSNumberFormatter new];
-                                        formatter.numberStyle = NSNumberFormatterDecimalStyle;
-                                        NSNumber *portNumber = [formatter numberFromString:port];
-                                        if (portNumber == nil) {
-                                          portNumber = [NSNumber numberWithInt:RCT_METRO_PORT];
-                                        }
-
-                                        [RCTBundleURLProvider sharedSettings].jsLocation =
-                                            [NSString stringWithFormat:@"%@:%d", ipAddress, portNumber.intValue];
-
-                                        if (bundleRoot.length == 0) {
-                                          [bundleManager resetBundleURL];
-                                        } else {
-                                          bundleManager.bundleURL = [[RCTBundleURLProvider sharedSettings]
-                                              jsBundleURLForBundleRoot:bundleRoot];
-                                        }
-
-                                        RCTTriggerReloadCommandListeners(@"Dev menu - apply changes");
-                                      } else if (response == NSAlertSecondButtonReturn) {
-                                        // Reset to Default
-                                        [weakSelf setDefaultJSBundle];
-                                      }
-                                      // Cancel - do nothing
-                                    }];
+                      NSModalResponse response = [alert runModal];
+                      
+                      if (response == NSAlertFirstButtonReturn) {
+                        // Apply Changes
+                        NSString *ipAddress = ipTextField.stringValue;
+                        NSString *port = portTextField.stringValue;
+                        NSString *bundleRoot = entrypointTextField.stringValue;
+
+                        if (ipAddress.length == 0 && port.length == 0) {
+                          [weakSelf setDefaultJSBundle];
+                          return;
+                        }
+
+                        NSNumberFormatter *formatter = [NSNumberFormatter new];
+                        formatter.numberStyle = NSNumberFormatterDecimalStyle;
+                        NSNumber *portNumber = [formatter numberFromString:port];
+                        if (portNumber == nil) {
+                          portNumber = [NSNumber numberWithInt:RCT_METRO_PORT];
+                        }
+
+                        [RCTBundleURLProvider sharedSettings].jsLocation =
+                            [NSString stringWithFormat:@"%@:%d", ipAddress, portNumber.intValue];
+
+                        if (bundleRoot.length == 0) {
+                          [bundleManager resetBundleURL];
+                        } else {
+                          bundleManager.bundleURL = [[RCTBundleURLProvider sharedSettings]
+                              jsBundleURLForBundleRoot:bundleRoot];
+                        }
+
+                        RCTTriggerReloadCommandListeners(@"Dev menu - apply changes");
+                      } else if (response == NSAlertSecondButtonReturn) {
+                        // Reset to Default
+                        [weakSelf setDefaultJSBundle];
+                      }
+                      // Cancel - do nothing
 #endif // macOS]
                     }]];
 
@@ -572,7 +571,7 @@ - (RCTDevMenuAlertActionHandler)alertActionHandlerForDevItem:(RCTDevMenuItem *__
 #else // [macOS
 - (NSMenu *)menu
 {
-  if ([_bridge.devSettings isSecondaryClickToShowDevMenuEnabled]) {
+  if ([((RCTDevSettings *)[_moduleRegistry moduleForName:"DevSettings"]) isSecondaryClickToShowDevMenuEnabled]) {
     NSMenu *menu = nil;
     if (_bridge) {
       NSString *desc = _bridge.bridgeDescription;