Skip to content

Commit b8881fa

Browse files
authored
ci(0.78): fix nx release not updating our lock file (#2599)
Backport of #2602
1 parent 92df3de commit b8881fa

File tree

9 files changed

+23
-15
lines changed

9 files changed

+23
-15
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
__default__: patch
3+
---
4+
5+
Implement paused in Debugger overlay

packages/nx-release-version/index.js

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
// @ts-check
22

33
const {REPO_ROOT} = require('../../scripts/consts');
4-
const JsVersionActions = require('@nx/js/src/release/version-actions').default;
4+
const {default: JsVersionActions, afterAllProjectsVersioned: baseAfterAllProjectsVersioned} = require('@nx/js/src/release/version-actions');
55
const fs = require('node:fs');
66
const path = require('node:path');
77

@@ -66,12 +66,15 @@ async function runSetVersion() {
6666
/**
6767
* Custom afterAllProjectsVersioned hook for React Native macOS
6868
* Updates React Native artifacts after all projects have been versioned
69-
* @param {string} _cwd - Current working directory (unused)
70-
* @param {object} _opts - Options object containing versioning information (unused)
69+
* @param {string} cwd - Current working directory
70+
* @param {object} opts - Options object containing versioning information
7171
* @returns {Promise<{changedFiles: string[], deletedFiles: string[]}>}
7272
*/
73-
const afterAllProjectsVersioned = async (_cwd, _opts) => {
74-
const changedFiles = [];
73+
const afterAllProjectsVersioned = async (cwd, opts) => {
74+
const baseResult = await baseAfterAllProjectsVersioned(cwd, opts);
75+
76+
const changedFiles = [...baseResult.changedFiles];
77+
const deletedFiles = [...baseResult.deletedFiles];
7578

7679
try {
7780
// Create the .rnm-publish file to indicate versioning has occurred
@@ -80,7 +83,7 @@ const afterAllProjectsVersioned = async (_cwd, _opts) => {
8083
// Update React Native artifacts
8184
const versionedFiles = await runSetVersion();
8285

83-
// Return the versioned files so Nx can track them
86+
// Add the versioned files to changed files
8487
changedFiles.push(...versionedFiles);
8588

8689
console.log('✅ Updated React Native artifacts');
@@ -93,7 +96,7 @@ const afterAllProjectsVersioned = async (_cwd, _opts) => {
9396

9497
return {
9598
changedFiles,
96-
deletedFiles: [],
99+
deletedFiles,
97100
};
98101
};
99102

packages/react-native/Libraries/Core/ReactNativeVersion.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ const version: $ReadOnly<{
1616
}> = {
1717
major: 0,
1818
minor: 78,
19-
patch: 5,
19+
patch: 4,
2020
prerelease: null,
2121
};
2222

packages/react-native/React/Base/RCTVersion.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
__rnVersion = @{
2424
RCTVersionMajor: @(0),
2525
RCTVersionMinor: @(78),
26-
RCTVersionPatch: @(5),
26+
RCTVersionPatch: @(4),
2727
RCTVersionPrerelease: [NSNull null],
2828
};
2929
});

packages/react-native/ReactAndroid/gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
VERSION_NAME=0.78.5
1+
VERSION_NAME=0.78.4
22
react.internal.publishingGroup=com.facebook.react
33

44
android.useAndroidX=true

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/systeminfo/ReactNativeVersion.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,6 @@ public class ReactNativeVersion {
1717
public static final Map<String, Object> VERSION = MapBuilder.<String, Object>of(
1818
"major", 0,
1919
"minor", 78,
20-
"patch", 5,
20+
"patch", 4,
2121
"prerelease", null);
2222
}

packages/react-native/ReactCommon/cxxreact/ReactNativeVersion.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ namespace facebook::react {
1717
constexpr struct {
1818
int32_t Major = 0;
1919
int32_t Minor = 78;
20-
int32_t Patch = 5;
20+
int32_t Patch = 4;
2121
std::string_view Prerelease = "";
2222
} ReactNativeVersion;
2323

packages/react-native/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-native-macos",
3-
"version": "0.78.5",
3+
"version": "0.78.4",
44
"description": "React Native for macOS",
55
"license": "MIT",
66
"repository": {
@@ -111,7 +111,7 @@
111111
},
112112
"dependencies": {
113113
"@jest/create-cache-key-function": "^29.6.3",
114-
"@react-native-macos/virtualized-lists": "0.78.5",
114+
"@react-native-macos/virtualized-lists": "0.78.4",
115115
"@react-native/assets-registry": "0.78.2",
116116
"@react-native/codegen": "0.78.2",
117117
"@react-native/community-cli-plugin": "0.78.2",

packages/virtualized-lists/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@react-native-macos/virtualized-lists",
3-
"version": "0.78.5",
3+
"version": "0.78.4",
44
"description": "Virtualized lists for React Native macOS.",
55
"license": "MIT",
66
"repository": {

0 commit comments

Comments
 (0)