Skip to content

Commit c1df4ad

Browse files
shwantonSaadnajmi
authored andcommitted
[fabric] Fix warning & formatting
1 parent 5f3faf6 commit c1df4ad

File tree

4 files changed

+2
-10
lines changed

4 files changed

+2
-10
lines changed

packages/react-native/Libraries/Text/TextInput/Singleline/RCTUITextField.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ NS_ASSUME_NONNULL_BEGIN
4545
#if !TARGET_OS_OSX // [macOS]
4646
@property (nonatomic, assign, getter=isEditable) BOOL editable;
4747
#else // [macOS
48-
@property (assign, getter=isEditable) BOOL editable;
48+
@property (atomic, assign, getter=isEditable) BOOL editable;
4949
#endif // macOS]
5050
@property (nonatomic, getter=isScrollEnabled) BOOL scrollEnabled;
5151
@property (nonatomic, strong, nullable) NSString *inputAccessoryViewID;
@@ -58,7 +58,7 @@ NS_ASSUME_NONNULL_BEGIN
5858
#if TARGET_OS_OSX // [macOS
5959
@property (nonatomic, copy, nullable) NSString *text;
6060
@property (nonatomic, copy, nullable) NSAttributedString *attributedText;
61-
@property (nonatomic, copy) NSDictionary<NSAttributedStringKey, id> *defaultTextAttributes;
61+
@property (nonatomic, strong, nullable) NSDictionary<NSAttributedStringKey, id> *defaultTextAttributes;
6262
@property (nullable, nonatomic, copy) NSDictionary<NSAttributedStringKey, id> *typingAttributes;
6363
@property (nonatomic, assign) NSTextAlignment textAlignment;
6464
@property (nonatomic, getter=isAutomaticTextReplacementEnabled) BOOL automaticTextReplacementEnabled;

packages/react-native/React/Fabric/Mounting/ComponentViews/LegacyViewManagerInterop/RCTLegacyViewManagerInteropComponentView.mm

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,6 @@
1616
#import <react/utils/ManagedObjectWrapper.h>
1717
#import "RCTLegacyViewManagerInteropCoordinatorAdapter.h"
1818

19-
#if TARGET_OS_OSX // [macOS
20-
#import <React/RCTView.h>
21-
#endif // macOS]
22-
2319
using namespace facebook::react;
2420

2521
static NSString *const kRCTLegacyInteropChildComponentKey = @"childComponentView";

packages/react-native/React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputUtils.h

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,7 @@ UITextAutocapitalizationType RCTUITextAutocapitalizationTypeFromAutocapitalizati
3030

3131
UIKeyboardAppearance RCTUIKeyboardAppearanceFromKeyboardAppearance(
3232
facebook::react::KeyboardAppearance keyboardAppearance);
33-
#endif // [macOS]
3433

35-
#if !TARGET_OS_OSX // [macOS]
3634
UITextSpellCheckingType RCTUITextSpellCheckingTypeFromOptionalBool(std::optional<bool> spellCheck);
3735

3836
UITextFieldViewMode RCTUITextFieldViewModeFromTextInputAccessoryVisibilityMode(

packages/react-native/React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputUtils.mm

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,7 @@ UIKeyboardAppearance RCTUIKeyboardAppearanceFromKeyboardAppearance(KeyboardAppea
103103
return UIKeyboardAppearanceDark;
104104
}
105105
}
106-
#endif // [macOS]
107106

108-
#if !TARGET_OS_OSX // [macOS]
109107
UITextSpellCheckingType RCTUITextSpellCheckingTypeFromOptionalBool(std::optional<bool> spellCheck)
110108
{
111109
return spellCheck.has_value() ? (*spellCheck ? UITextSpellCheckingTypeYes : UITextSpellCheckingTypeNo)

0 commit comments

Comments
 (0)