Skip to content

Commit c4ccda3

Browse files
okwasniewskigabrieldonadel
authored andcommitted
fix: return nullptr when USE_THIRD_PARTY_JSC is set to true (facebook#49781)
Summary: When setting `USE_THIRD_PARTY_JSC=1`, we don't return anything from createJSRuntimeFactory function: ![CleanShot 2025-03-03 at 13 05 24@2x](https://github.com/user-attachments/assets/090ca47a-77f8-4a1b-9171-79b5e4ce91fb) It's meant to be overwritten, but we must satisfy the compiler. ## Changelog: [IOS] [FIXED] - return nullptr when USE_THIRD_PARTY_JSC is set to true Pull Request resolved: facebook#49781 Test Plan: CI Green Reviewed By: cortinico Differential Revision: D70486837 Pulled By: cipolleschi fbshipit-source-id: c09622f75608dc203d41167fc375a000a2f12e37
1 parent 117168e commit c4ccda3

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

packages/react-native/Libraries/AppDelegate/RCTDefaultReactNativeFactoryDelegate.mm

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,8 @@ - (JSRuntimeFactoryRef)createJSRuntimeFactory
4949
return jsrt_create_hermes_factory();
5050
#elif USE_THIRD_PARTY_JSC != 1
5151
return jsrt_create_jsc_factory();
52+
#else
53+
return nullptr;
5254
#endif
5355
}
5456

0 commit comments

Comments
 (0)