Skip to content

Commit dac509c

Browse files
authored
Add a mac test plan to improve our confidence in fixes going into RN moving forward. Check for safe memory usage and concurrency problems (#190)
1 parent c610b2e commit dac509c

File tree

3 files changed

+63
-1
lines changed

3 files changed

+63
-1
lines changed
Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
{
2+
"configurations" : [
3+
{
4+
"id" : "AFD9E2BD-E33C-4C4A-A384-5EAE06C9A403",
5+
"name" : "Memory Checking",
6+
"options" : {
7+
"addressSanitizer" : {
8+
"detectStackUseAfterReturn" : true,
9+
"enabled" : true
10+
},
11+
"nsZombieEnabled" : true
12+
}
13+
},
14+
{
15+
"id" : "25FE48EC-9A2D-4569-A6B2-13F09014C2AB",
16+
"name" : "Concurrency",
17+
"options" : {
18+
"testExecutionOrdering" : "random",
19+
"undefinedBehaviorSanitizerEnabled" : true
20+
}
21+
}
22+
],
23+
"defaultOptions" : {
24+
"codeCoverage" : false,
25+
"environmentVariableEntries" : [
26+
{
27+
"key" : "CI_USE_PACKAGER",
28+
"value" : "1"
29+
}
30+
],
31+
"targetForVariableExpansion" : {
32+
"containerPath" : "container:RNTester.xcodeproj",
33+
"identifier" : "18FC77851EF4770B002B3F17",
34+
"name" : "RNTester-macOS"
35+
}
36+
},
37+
"testTargets" : [
38+
{
39+
"target" : {
40+
"containerPath" : "container:RNTester.xcodeproj",
41+
"identifier" : "18FC779A1EF4770B002B3F17",
42+
"name" : "RNTester-macOSUnitTests"
43+
}
44+
},
45+
{
46+
"target" : {
47+
"containerPath" : "container:RNTester.xcodeproj",
48+
"identifier" : "18FC77A51EF4770B002B3F17",
49+
"name" : "RNTester-macOSIntegrationTests"
50+
}
51+
}
52+
],
53+
"version" : 1
54+
}

RNTester/RNTester.xcodeproj/project.pbxproj

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -916,6 +916,7 @@
916916
8385CF051B8747A000C6273E /* RCTImageLoaderHelpers.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = RCTImageLoaderHelpers.h; sourceTree = "<group>"; };
917917
9F1534BD233AB44F006DFE44 /* JavaScriptCore.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = JavaScriptCore.framework; path = Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/JavaScriptCore.framework; sourceTree = DEVELOPER_DIR; };
918918
9F1C4D00236CB06B0022EC0D /* RNTesterTestPlan_iOS.xctestplan */ = {isa = PBXFileReference; lastKnownFileType = text; path = RNTesterTestPlan_iOS.xctestplan; sourceTree = "<group>"; };
919+
9F4D1F022375E7A10012B4A9 /* RNTesterTestPlan_mac.xctestplan */ = {isa = PBXFileReference; lastKnownFileType = text; path = RNTesterTestPlan_mac.xctestplan; sourceTree = "<group>"; };
919920
9F5C1923230F46CB00E3E5A7 /* JavaScriptCore.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = JavaScriptCore.framework; path = Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/System/Library/Frameworks/JavaScriptCore.framework; sourceTree = DEVELOPER_DIR; };
920921
9FBFA513233C7E4C003D9A8D /* RNTesterBundle-macOS.bundle */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = "RNTesterBundle-macOS.bundle"; sourceTree = BUILT_PRODUCTS_DIR; };
921922
9FBFA515233C7E4C003D9A8D /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; };
@@ -1362,6 +1363,7 @@
13621363
18FC77871EF4770B002B3F17 /* RNTester-macOS */ = {
13631364
isa = PBXGroup;
13641365
children = (
1366+
9F4D1F022375E7A10012B4A9 /* RNTesterTestPlan_mac.xctestplan */,
13651367
18FC77881EF4770B002B3F17 /* AppDelegate.h */,
13661368
18FC77891EF4770B002B3F17 /* AppDelegate.m */,
13671369
18FC778E1EF4770B002B3F17 /* ViewController.h */,

RNTester/RNTester.xcodeproj/xcshareddata/xcschemes/RNTester-macOS.xcscheme

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<?xml version="1.0" encoding="UTF-8"?>
22
<Scheme
33
LastUpgradeVersion = "0830"
4-
version = "1.3">
4+
version = "1.7">
55
<BuildAction
66
parallelizeBuildables = "NO"
77
buildImplicitDependencies = "YES">
@@ -64,6 +64,12 @@
6464
ReferencedContainer = "container:RNTester.xcodeproj">
6565
</BuildableReference>
6666
</MacroExpansion>
67+
<TestPlans>
68+
<TestPlanReference
69+
reference = "container:RNTester-macOS/RNTesterTestPlan_mac.xctestplan"
70+
default = "YES">
71+
</TestPlanReference>
72+
</TestPlans>
6773
<Testables>
6874
<TestableReference
6975
skipped = "NO">

0 commit comments

Comments
 (0)