Skip to content

Commit deea423

Browse files
rubennortefacebook-github-bot
authored andcommitted
Remove verification function from ReactFabricPublicInstance benchmark (facebook#48588)
Summary: Pull Request resolved: facebook#48588 Changelog: [internal] This has proved to be very CI and makes it fail a lot, so we're removing this for now. Reviewed By: javache Differential Revision: D67985917 fbshipit-source-id: 5ec7c1387ddfb8fb2a4e90450a98cb3caea9399f
1 parent bb6bbfc commit deea423

File tree

1 file changed

+0
-19
lines changed

1 file changed

+0
-19
lines changed

packages/react-native/Libraries/ReactNative/ReactFabricPublicInstance/__tests__/ReactFabricPublicInstance-benchmark-itest.js

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import type {
1818
import ReactNativeElement from '../../../../src/private/webapis/dom/nodes/ReactNativeElement';
1919
import ReactFabricHostComponent from '../../../ReactNative/ReactFabricPublicInstance/ReactFabricHostComponent';
2020
import {unstable_benchmark} from '@react-native/fantom';
21-
import nullthrows from 'nullthrows';
2221

2322
// Create fake parameters for the class.
2423
const tag = 11;
@@ -40,22 +39,4 @@ unstable_benchmark
4039
.add('ReactFabricHostComponent', () => {
4140
// eslint-disable-next-line no-new
4241
new ReactFabricHostComponent(tag, viewConfig, internalInstanceHandle);
43-
})
44-
.verify(([modernImplResults, legacyImplResults]) => {
45-
const minMedian = Math.min(
46-
nullthrows(modernImplResults.latency.p50),
47-
nullthrows(legacyImplResults.latency.p50),
48-
);
49-
const maxMedian = Math.max(
50-
nullthrows(modernImplResults.latency.p50),
51-
nullthrows(legacyImplResults.latency.p50),
52-
);
53-
54-
const medianDifferencePercent = ((maxMedian - minMedian) / minMedian) * 100;
55-
console.log(
56-
`Difference in p50 values between ReactFabricHostComponent and ReactNativeElement is ${medianDifferencePercent.toFixed(2)}%`,
57-
);
58-
59-
// No implementation should be more than 25% slower than the other.
60-
expect(medianDifferencePercent).toBeLessThan(25);
6142
});

0 commit comments

Comments
 (0)