You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[fabric] Fix hit testing calls going through LegacyViewManagerInteropComponent
Summary:
Hit testing in RN macOS uses the view coordinate space instead of the macOS superview coordinate space. The RCTView hitTest implementation gets called from Fabric when Paper components are loaded through the `LegacyViewManagerInteropComponent`.
When the Paper component has Fabric child components, the hitTest implementation would treat those as native macOS views.
This diff adds a selector check to detect Fabric RCTViewComponentView instances and apply the right point conversion. The selector check allows to have the right behavior without having to import Fabric classes in Paper code.
Test Plan:
- Run Workplace Chat with Fabric enabled
- Click on a thread title in the thread list
- With the fix, the thread gets selected
Reviewers: shawndempsey, ericroz, chpurrer, #rn-desktop
Reviewed By: shawndempsey, ericroz
Differential Revision: https://phabricator.intern.facebook.com/D49083593
Tasks: T163162857
0 commit comments