Merge commit '166ea3166cbb6ab665accbdc18147d8f5ed4be46' into 0.78.1-merge

Author: Saadnajmi

.github/actions/build-android/action.yml

@@ -20,8 +20,6 @@ runs:
     - name: Set React Native Version
       shell: bash
       run: node ./scripts/releases/set-rn-artifacts-version.js --build-type ${{ inputs.release-type }}
-      # We don't want to re-set the artifacts version if we're on the release branch.
-      if: ${{ !contains(github.ref, '-stable') }}
     - name: Setup gradle
       uses: ./.github/actions/setup-gradle
       with:

.github/workflow-scripts/publishTemplate.js

@@ -86,7 +86,7 @@ module.exports.verifyPublishedTemplate = async (
         return;
       }
       log(
-        `🐌 ${TEMPLATE_NPM_PKG}@latest → ${pkg.version} on npm and not ${version} as expected, retrying...`,
+        `🐌 ${TEMPLATE_NPM_PKG}@latest → ${json.version} on npm and not ${version} as expected, retrying...`,
       );
     } catch (e) {
       log(`Nope, fetch failed: ${e.message}`);

.github/workflows/test-all.yml

@@ -157,7 +157,7 @@ jobs:
           react-native-version: ${{ needs.prepare_hermes_workspace.outputs.react-native-version }}
 
   test_ios_rntester:
-    runs-on: macos-13
+    runs-on: macos-13-large
     needs:
       [build_apple_slices_hermes, prepare_hermes_workspace, build_hermes_macos]
     env:
@@ -369,6 +369,11 @@ jobs:
             sed -i 's/newArchEnabled=true/newArchEnabled=false/' android/gradle.properties
           fi
 
+          if [[ ${{matrix.jsengine}} == "JSC" ]]; then
+            echo "Using JSC instead of Hermes"
+            sed -i 's/hermesEnabled=true/hermesEnabled=false/' android/gradle.properties
+          fi
+
           # Build
           cd android
           CAPITALIZED_FLAVOR=$(echo "${{ matrix.flavor }}" | awk '{print toupper(substr($0, 1, 1)) substr($0, 2)}')

package.json

@@ -54,8 +54,8 @@
     "@definitelytyped/dtslint": "^0.0.127",
     "@jest/create-cache-key-function": "^29.6.3",
     "@nx/js": "~20.0.0",
-    "@react-native/metro-babel-transformer": "0.77.0-main",
-    "@react-native/metro-config": "0.77.0-main",
+    "@react-native/metro-babel-transformer": "0.78.1",
+    "@react-native/metro-config": "0.78.1",
     "@tsconfig/node18": "1.0.1",
     "@types/react": "^19.0.0",
     "@typescript-eslint/parser": "^7.1.1",

packages/assets/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@react-native/assets-registry",
-  "version": "0.77.0-main",
+  "version": "0.78.1",
   "description": "Asset support code for React Native.",
   "license": "MIT",
   "repository": {

packages/babel-plugin-codegen/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@react-native/babel-plugin-codegen",
-  "version": "0.77.0-main",
+  "version": "0.78.1",
   "description": "Babel plugin to generate native module and view manager code for React Native.",
   "license": "MIT",
   "repository": {
@@ -26,7 +26,7 @@
   ],
   "dependencies": {
     "@babel/traverse": "^7.25.3",
-    "@react-native/codegen": "0.77.0-main"
+    "@react-native/codegen": "0.78.1"
   },
   "devDependencies": {
     "@babel/core": "^7.25.2"

packages/community-cli-plugin/README.md

@@ -15,7 +15,7 @@ Start the React Native development server.
 #### Usage
 
 ```sh
-npx react-native start [options]
+npx @react-native-community/cli start [options]
 ```
 
 #### Options
@@ -37,6 +37,7 @@ npx react-native start [options]
 | `--cert <path>` | Specify path to a custom SSL cert. |
 | `--config <string>` | Path to the CLI configuration file. |
 | `--no-interactive` | Disable interactive mode. |
+| `--client-logs` | **[Deprecated]** Enable plain text JavaScript log streaming for all connected apps. |
 
 ### `bundle`
 
@@ -45,7 +46,7 @@ Build the bundle for the provided JavaScript entry file.
 #### Usage
 
 ```sh
-npx react-native bundle --entry-file <path> [options]
+npx @react-native-community/cli bundle --entry-file <path> [options]
 ```
 
 #### Options

packages/community-cli-plugin/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@react-native/community-cli-plugin",
-  "version": "0.77.0-main",
+  "version": "0.78.1",
   "description": "Core CLI commands for React Native",
   "keywords": [
     "react-native",
@@ -22,8 +22,8 @@
     "dist"
   ],
   "dependencies": {
-    "@react-native/dev-middleware": "0.77.0-main",
-    "@react-native/metro-babel-transformer": "0.77.0-main",
+    "@react-native/dev-middleware": "0.78.1",
+    "@react-native/metro-babel-transformer": "0.78.1",
     "chalk": "^4.0.0",
     "debug": "^2.2.0",
     "invariant": "^2.2.4",
@@ -37,10 +37,10 @@
     "metro-resolver": "^0.81.0"
   },
   "peerDependencies": {
-    "@react-native-community/cli-server-api": "*"
+    "@react-native-community/cli": "*"
   },
   "peerDependenciesMeta": {
-    "@react-native-community/cli-server-api": {
+    "@react-native-community/cli": {
       "optional": true
     }
   },

packages/community-cli-plugin/src/commands/start/index.js

@@ -95,6 +95,14 @@ const startCommand: Command = {
       name: '--no-interactive',
       description: 'Disables interactive mode',
     },
+    {
+      name: '--client-logs',
+      description:
+        '[Deprecated] Enable plain text JavaScript log streaming for all ' +
+        'connected apps. This feature is deprecated and will be removed in ' +
+        'future.',
+      default: false,
+    },
   ],
 };
 

packages/community-cli-plugin/src/commands/start/middleware.js

@@ -9,7 +9,8 @@
  * @oncall react_native
  */
 
-import type {NextHandleFunction, Server} from 'connect';
+import typeof * as CLIServerAPI from '@react-native-community/cli-server-api';
+import type {Server} from 'connect';
 import type {TerminalReportableEvent} from 'metro/src/lib/TerminalReporter';
 
 const debug = require('debug')('ReactNative:CommunityCliPlugin');
@@ -30,10 +31,6 @@ type MiddlewareReturn = {
   ...
 };
 
-const noopNextHandle: NextHandleFunction = (req, res, next) => {
-  next();
-};
-
 // $FlowFixMe
 const unusedStubWSServer: ws$WebSocketServer = {};
 // $FlowFixMe
@@ -45,6 +42,12 @@ const communityMiddlewareFallback = {
     port: number,
     watchFolders: $ReadOnlyArray<string>,
   }): MiddlewareReturn => ({
+    // FIXME: Several features will break without community middleware and
+    // should be migrated into core.
+    // e.g. used by Libraries/Core/Devtools:
+    // - /open-stack-frame
+    // - /open-url
+    // - /symbolicate
     middleware: unusedMiddlewareStub,
     websocketEndpoints: {},
     messageSocketEndpoint: {
@@ -59,23 +62,34 @@ const communityMiddlewareFallback = {
       reportEvent: (event: TerminalReportableEvent) => {},
     },
   }),
-  indexPageMiddleware: noopNextHandle,
 };
 
 // Attempt to use the community middleware if it exists, but fallback to
 // the stubs if it doesn't.
 try {
-  const community = require('@react-native-community/cli-server-api');
-  communityMiddlewareFallback.indexPageMiddleware =
-    community.indexPageMiddleware;
+  // `@react-native-community/cli` is an optional peer dependency of this
+  // package, and should be a dev dependency of the host project (via the
+  // community template's package.json).
+  const communityCliPath = require.resolve('@react-native-community/cli');
+
+  // `@react-native-community/cli-server-api` is a dependency of
+  // `@react-native-community/cli`, but is not re-exported by it, so we need
+  // to resolve the former through the latter.
+  const communityCliServerApiPath = require.resolve(
+    '@react-native-community/cli-server-api',
+    {paths: [communityCliPath]},
+  );
+  // $FlowIgnore[unsupported-syntax] dynamic import
+  const communityCliServerApi: CLIServerAPI = require(
+    communityCliServerApiPath,
+  );
+  // $FlowIgnore[unsupported-syntax] dynamic import
   communityMiddlewareFallback.createDevServerMiddleware =
-    community.createDevServerMiddleware;
+    communityCliServerApi.createDevServerMiddleware;
 } catch {
   debug(`⚠️ Unable to find @react-native-community/cli-server-api
 Starting the server without the community middleware.`);
 }
 
 export const createDevServerMiddleware =
   communityMiddlewareFallback.createDevServerMiddleware;
-export const indexPageMiddleware =
-  communityMiddlewareFallback.indexPageMiddleware;