Implement isKeyboardFocusable

Saadnajmi · Saadnajmi · commit eb861d7356bd · 2026-01-08T23:28:41.000-06:00
diff --git a/packages/react-native/ReactCommon/react/renderer/components/view/ConcreteViewShadowNode.h b/packages/react-native/ReactCommon/react/renderer/components/view/ConcreteViewShadowNode.h
@@ -118,7 +118,6 @@ class ConcreteViewShadowNode : public ConcreteShadowNode<
       BaseShadowNode::orderIndex_ = 0;
     }
 
-#if !TARGET_OS_OSX // [macOS]
     bool isKeyboardFocusable =
         HostPlatformViewTraitsInitializer::isKeyboardFocusable(props) ||
         props.accessible;
@@ -128,7 +127,6 @@ class ConcreteViewShadowNode : public ConcreteShadowNode<
     } else {
       BaseShadowNode::traits_.unset(ShadowNodeTraits::Trait::KeyboardFocusable);
     }
-#endif // [macOS]
   }
 };
 
diff --git a/packages/react-native/ReactCommon/react/renderer/components/view/platform/macos/react/renderer/components/view/HostPlatformViewTraitsInitializer.h b/packages/react-native/ReactCommon/react/renderer/components/view/platform/macos/react/renderer/components/view/HostPlatformViewTraitsInitializer.h
@@ -23,4 +23,8 @@ inline bool formsView(const ViewProps& props) {
   return props.focusable;
 }
 
+inline bool isKeyboardFocusable(const ViewProps& props) {
+  return props.focusable;
+}
+
 } // namespace facebook::react::HostPlatformViewTraitsInitializer

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,6 @@ class ConcreteViewShadowNode : public ConcreteShadowNode<`
`118`	`118`	`BaseShadowNode::orderIndex_ = 0;`
`119`	`119`	`}`
`120`	`120`
`121`		`-#if !TARGET_OS_OSX // [macOS]`
`122`	`121`	`bool isKeyboardFocusable =`
`123`	`122`	`HostPlatformViewTraitsInitializer::isKeyboardFocusable(props) \|\|`
`124`	`123`	`props.accessible;`
`@@ -128,7 +127,6 @@ class ConcreteViewShadowNode : public ConcreteShadowNode<`
`128`	`127`	`} else {`
`129`	`128`	`BaseShadowNode::traits_.unset(ShadowNodeTraits::Trait::KeyboardFocusable);`
`130`	`129`	`}`
`131`		`-#endif // [macOS]`
`132`	`130`	`}`
`133`	`131`	`};`
`134`	`132`
Original file line number	Diff line number	Diff line change
`@@ -23,4 +23,8 @@ inline bool formsView(const ViewProps& props) {`
`23`	`23`	`return props.focusable;`
`24`	`24`	`}`
`25`	`25`
	`26`	`+inline bool isKeyboardFocusable(const ViewProps& props) {`
	`27`	`+ return props.focusable;`
	`28`	`+}`
	`29`	`+`
`26`	`30`	`} // namespace facebook::react::HostPlatformViewTraitsInitializer`