chore: avoid fs/promises unless multi-tasking (#2406)

Author: tido64

scripts/apply-config-plugins.mjs

@@ -1,7 +1,7 @@
 #!/usr/bin/env node
 // @ts-check
 
-import * as fs from "node:fs/promises";
+import * as fs from "node:fs";
 import * as path from "node:path";
 import { parseArgs } from "node:util";
 import { findFile } from "./helpers.js";
@@ -17,7 +17,7 @@ async function main(projectRoot = process.cwd(), platforms) {
     throw new Error("Failed to find `package.json`");
   }
 
-  const content = await fs.readFile(packageJsonPath, { encoding: "utf-8" });
+  const content = fs.readFileSync(packageJsonPath, { encoding: "utf-8" });
   if (!content.includes('"@expo/config-plugins"')) {
     return;
   }

scripts/config-plugins/apply.mjs

@@ -1,5 +1,5 @@
 // @ts-check
-import * as fs from "node:fs/promises";
+import * as fs from "node:fs";
 import { withPlugins } from "./ExpoConfigPlugins.mjs";
 import { compileModsAsync } from "./plugins/mod-compiler.mjs";
 import { withInternal } from "./plugins/withInternal.mjs";
@@ -14,7 +14,7 @@ export async function applyConfigPlugins({ appJsonPath, ...info }) {
     return;
   }
 
-  const content = await fs.readFile(appJsonPath, { encoding: "utf-8" });
+  const content = fs.readFileSync(appJsonPath, { encoding: "utf-8" });
   const { plugins, ...config } = JSON.parse(content);
   if (!Array.isArray(plugins) || plugins.length === 0) {
     return;

scripts/internal/generate-manifest.mts

@@ -1,6 +1,6 @@
 // eslint-disable-next-line no-restricted-imports
 import type { SchemaObject } from "ajv";
-import * as fs from "node:fs/promises";
+import * as fs from "node:fs";
 import * as path from "node:path";
 import { URL, fileURLToPath } from "node:url";
 import { generateSchema } from "../schema.mjs";
@@ -200,7 +200,7 @@ function generateType(
 /**
  * Generates manifest data models and writes them to specified path.
  */
-async function generate(schema: SchemaObject, output: string) {
+function generate(schema: SchemaObject, output: string) {
   const lang = getLanguage(output);
   const lines = [
     `// This file was generated by ${path.basename(thisScript)}.`,
@@ -226,17 +226,17 @@ async function generate(schema: SchemaObject, output: string) {
 
   const code = lines.join("\n");
 
-  const content = await fs.readFile(output, { encoding: "utf-8" });
+  const content = fs.readFileSync(output, { encoding: "utf-8" });
   if (content !== code) {
-    fs.writeFile(output, code);
+    fs.writeFileSync(output, code);
   }
 }
 
 function main() {
   const schema = generateSchema();
   const projectDir = fileURLToPath(new URL("../..", import.meta.url));
 
-  [
+  const outputs = [
     path.join(
       projectDir,
       "android",
@@ -252,7 +252,15 @@ function main() {
     ),
     path.join(projectDir, "ios", "ReactTestApp", "Manifest.swift"),
     path.join(projectDir, "windows", "Shared", "Manifest.h"),
-  ].forEach((output) => generate(schema, output).catch(console.error));
+  ];
+
+  for (const output of outputs) {
+    try {
+      generate(schema, output);
+    } catch (e) {
+      console.error(e);
+    }
+  }
 }
 
 main();

scripts/internal/generate-schema.mts

@@ -63,10 +63,12 @@ export async function readDocumentation(): Promise<Partial<Docs>> {
     "windows.certificateThumbprint",
   ];
 
+  const fileReadOptions = { encoding: "utf-8" } as const;
+
   await Promise.all(
     keys.map(async (name) => {
       const filename = path.join(docsDir, name + ".md");
-      const md = await fs.readFile(filename, { encoding: "utf-8" });
+      const md = await fs.readFile(filename, fileReadOptions);
       docs[name] = stripCarriageReturn(md).trim();
     })
   );

test/android/gradle.ts

@@ -77,11 +77,9 @@ async function makeProject(
   await writeAllFiles(files, packagePath);
 
   try {
-    await fsp.symlink(
-      fileURLToPath(new URL("../../example/node_modules", import.meta.url)),
-      path.join(packagePath, "node_modules"),
-      "dir"
-    );
+    const target = new URL("../../example/node_modules", import.meta.url);
+    const nodeModulesDir = path.join(packagePath, "node_modules");
+    fs.symlinkSync(fileURLToPath(target), nodeModulesDir, "dir");
   } catch (e) {
     if (e && typeof e === "object" && "code" in e && e.code !== "EEXIST") {
       throw e;