fix(android): bump NDK to r23c (#1168)

Author: tido64

android/dependencies.gradle

@@ -9,16 +9,23 @@ ext {
     minSdkVersion = 23
     targetSdkVersion = 29
 
+    def reactNativeVersion = getPackageVersionNumber("react-native", rootDir)
+    def useAndroidPlugin_7_2 = reactNativeVersion > 0 && reactNativeVersion < 7100
+
     // We need only set `ndkVersion` when building react-native from source.
     if (rootProject.hasProperty("ANDROID_NDK_VERSION")) {
         ndkVersion = rootProject.properties["ANDROID_NDK_VERSION"]
-    } else if (System.properties["os.arch"] == "aarch64") {
-        // Android NDK added support for Apple M1 in r24:
-        // https://github.com/android/ndk/wiki/Changelog-r24
-        ndkVersion = "24.0.8215888"
+    } else if (System.properties["os.arch"] == "aarch64" && useAndroidPlugin_7_2) {
+        // NDK r23c has been patched to support Apple M1 and is default in AGP
+        // 7.3.0. Prior to 0.71, we still need to set `ndkVersion` because we'll
+        // be using AGP 7.2.2 (see `androidPluginVersion` below).
+        // Note that even though newer 23.x versions exist, we'll stick to AGP's
+        // default. See also
+        // https://developer.android.com/studio/releases/gradle-plugin#compatibility-7-3-0
+        ndkVersion = "23.1.7779620"
     }
 
-    androidPluginVersion = getPackageVersionNumber("react-native", rootDir) < 7100
+    androidPluginVersion = useAndroidPlugin_7_2
         ? "7.2.2"
         : "7.3.0"
     kotlinVersion = rootProject.hasProperty("KOTLIN_VERSION")