fix: support more extensions when looking for react-native.config.* (#2430)

Author: tido64

.github/actions/setup-toolchain/action.yml

@@ -13,6 +13,9 @@ inputs:
   java-version:
     description: Desired Java version
     default: "17"
+  node-version:
+    description: Desired Node version
+    default: "22"
   xcode-developer-dir:
     description: Set the path for the active Xcode developer directory
 runs:
@@ -72,7 +75,7 @@ runs:
     - name: Set up Node.js
       uses: actions/[email protected]
       with:
-        node-version: "22"
+        node-version: ${{ inputs.node-version }}
         cache: ${{ inputs.cache-npm-dependencies }}
     - name: Set up Xcode
       if: ${{ inputs.xcode-developer-dir != '' }}

.github/workflows/build.yml

@@ -550,6 +550,7 @@ jobs:
         uses: ./.github/actions/setup-toolchain
         with:
           platform: windows
+          node-version: "22.13"
       - name: Set up react-native@canary
         if: ${{ github.event_name == 'schedule' }}
         uses: ./.github/actions/setup-react-native
@@ -606,6 +607,7 @@ jobs:
         uses: ./.github/actions/setup-toolchain
         with:
           platform: windows
+          node-version: "22.13"
       - name: Initialize test app
         uses: ./.github/actions/init-test-app
         with:

scripts/configure-projects.js

@@ -1,6 +1,8 @@
 // @ts-check
 "use strict";
 
+/** @import { ProjectConfig, ProjectParams } from "./types.js"; */
+
 /**
  * This script (and its dependencies) currently cannot be converted to ESM
  * because it is consumed in `react-native.config.js`.
@@ -19,7 +21,61 @@ const {
   v,
 } = require("./helpers");
 
-/** @import { ProjectConfig, ProjectParams } from "./types.js"; */
+/**
+ * Finds `react-native.config.[ts,mjs,cjs,js]`.
+ *
+ * @note A naive search on disk might yield false positives so we also try to
+ * use the stack trace to find it. This currently works in Node (V8) and Bun
+ * (JSC).
+ *
+ * @returns {string} Path to `react-native.config.[ts,mjs,cjs,js]`
+ */
+function findReactNativeConfig(fs = nodefs) {
+  // stack[0] holds this file
+  // stack[1] holds where this function was called
+  // stack[2] holds the file we're interested in
+  const position = 2;
+  if (position < Error.stackTraceLimit) {
+    const orig_prepareStackTrace = Error.prepareStackTrace;
+    let stack;
+    try {
+      Error.prepareStackTrace = (_, stack) => stack;
+      stack = new Error().stack;
+    } finally {
+      Error.prepareStackTrace = orig_prepareStackTrace;
+    }
+
+    if (Array.isArray(stack)) {
+      const callsite = stack[position];
+      if (
+        callsite &&
+        typeof callsite === "object" &&
+        "getFileName" in callsite
+      ) {
+        const file = callsite.getFileName();
+        if (path.basename(file).startsWith("react-native.config.")) {
+          return file;
+        }
+      }
+    }
+  }
+
+  const configFiles = [
+    "react-native.config.ts",
+    "react-native.config.mjs",
+    "react-native.config.cjs",
+    "react-native.config.js",
+  ];
+
+  for (const file of configFiles) {
+    const reactNativeConfig = findNearest(file, undefined, fs);
+    if (reactNativeConfig) {
+      return reactNativeConfig;
+    }
+  }
+
+  throw new Error("Failed to find `react-native.config.[ts,mjs,cjs,js]`");
+}
 
 /**
  * Returns the version number of a React Native dependency.
@@ -94,14 +150,7 @@ function windowsProjectPath(solutionFile, fs = nodefs) {
  * @returns {Partial<ProjectParams>}
  */
 function configureProjects({ android, ios, windows }, fs = nodefs) {
-  const reactNativeConfig = findNearest(
-    "react-native.config.js",
-    undefined,
-    fs
-  );
-  if (!reactNativeConfig) {
-    throw new Error("Failed to find `react-native.config.js`");
-  }
+  const reactNativeConfig = findReactNativeConfig(fs);
 
   /** @type {Partial<ProjectParams>} */
   const config = {};
@@ -154,5 +203,6 @@ function configureProjects({ android, ios, windows }, fs = nodefs) {
 
 exports.configureProjects = configureProjects;
 exports.internalForTestingPurposesOnly = {
+  findReactNativeConfig,
   getAndroidPackageName,
 };

test/configure-projects.test.ts

@@ -1,4 +1,4 @@
-import { deepEqual, equal, fail } from "node:assert/strict";
+import { deepEqual, equal, fail, ok, throws } from "node:assert/strict";
 import * as nodefs from "node:fs";
 import * as path from "node:path";
 import { describe, it } from "node:test";
@@ -82,6 +82,34 @@ describe("configureProjects()", () => {
   });
 });
 
+describe("findReactNativeConfig()", () => {
+  const { findReactNativeConfig } = internalForTestingPurposesOnly;
+
+  const configFiles = [
+    "react-native.config.ts",
+    "react-native.config.mjs",
+    "react-native.config.cjs",
+    "react-native.config.js",
+  ];
+
+  it("throws if no config file is found", () => {
+    throws(
+      () => findReactNativeConfig({ ...nodefs, existsSync: () => false }),
+      new Error("Failed to find `react-native.config.[ts,mjs,cjs,js]`")
+    );
+  });
+
+  for (const configFile of configFiles) {
+    it(`finds '${configFile}'`, () => {
+      const result = findReactNativeConfig({
+        ...nodefs,
+        existsSync: (p) => typeof p === "string" && p.endsWith(configFile),
+      });
+      ok(result.endsWith(configFile));
+    });
+  }
+});
+
 describe("getAndroidPackageName()", () => {
   const { getAndroidPackageName } = internalForTestingPurposesOnly;