chore: extend test script to support macOS and visionOS

Author: tido64

scripts/testing/test-matrix.mts

@@ -18,16 +18,34 @@ type PlatformConfig = {
   engines: ReadonlyArray<"hermes" | "jsc">;
   isAvailable: (config: Required<BuildConfig>) => boolean;
   prebuild: (config: Required<BuildConfig>) => Promise<void>;
+  requiresManualTesting?: boolean;
 };
 
 const DEFAULT_PLATFORMS = ["android", "ios"];
 const TEST_VARIANTS = ["paper", "fabric"] as const;
 
+function isVariantSupported({ version, variant }: Required<BuildConfig>) {
+  return variant === "fabric" || toVersionNumber(version) < v(0, 82, 0);
+}
+
+function isAppleVariantSupported(config: Required<BuildConfig>) {
+  if (process.platform !== "darwin") {
+    return false;
+  }
+
+  const { version, engine } = config;
+  if (engine === "jsc" && toVersionNumber(version) >= v(0, 80, 0)) {
+    return false;
+  }
+
+  return isVariantSupported(config);
+}
+
 const PLATFORM_CONFIG: Record<TargetPlatform, PlatformConfig> = {
   android: {
     name: "Android",
     engines: ["hermes"],
-    isAvailable: ({ engine }) => engine === "hermes",
+    isAvailable: isVariantSupported,
     prebuild: ({ variant }) => {
       if (variant === "fabric") {
         const properties = "android/gradle.properties";
@@ -43,36 +61,29 @@ const PLATFORM_CONFIG: Record<TargetPlatform, PlatformConfig> = {
   ios: {
     name: "iOS",
     engines: ["jsc", "hermes"],
-    isAvailable: ({ version, engine }) => {
-      if (process.platform !== "darwin") {
-        return false;
-      }
-
-      if (engine === "jsc" && toVersionNumber(version) >= v(0, 80, 0)) {
-        return false;
-      }
-
-      return true;
-    },
+    isAvailable: isAppleVariantSupported,
     prebuild: installPods,
   },
   macos: {
     name: "macOS",
     engines: ["jsc", "hermes"],
-    isAvailable: () => false,
+    isAvailable: isAppleVariantSupported,
     prebuild: installPods,
+    requiresManualTesting: true,
   },
   visionos: {
     name: "visionOS",
     engines: ["jsc", "hermes"],
-    isAvailable: () => false,
+    isAvailable: isAppleVariantSupported,
     prebuild: installPods,
+    requiresManualTesting: true,
   },
   windows: {
     name: "Windows",
     engines: ["hermes"],
     isAvailable: () => false,
     prebuild: () => Promise.resolve(),
+    requiresManualTesting: true,
   },
 };
 
@@ -124,11 +135,11 @@ function validatePlatforms(platforms: string[]): TargetPlatform[] {
     switch (platform) {
       case "android":
       case "ios":
+      case "macos":
+      case "visionos":
         filtered.push(platform);
         break;
 
-      case "macos":
-      case "visionos":
       case "windows":
         log(yellow(`⚠ Unsupported platform: ${platform}`));
         break;
@@ -153,6 +164,14 @@ function parseArgs(args: string[]) {
         description: "Test iOS",
         type: "boolean",
       },
+      macos: {
+        description: "Test macOS",
+        type: "boolean",
+      },
+      visionos: {
+        description: "Test visionOS",
+        type: "boolean",
+      },
     },
     strict: true,
     allowPositionals: true,
@@ -168,10 +187,10 @@ function parseArgs(args: string[]) {
   };
 }
 
-function prestart() {
+function waitForUserInput(message: string): Promise<void> {
   return !process.stdin.isTTY
     ? Promise.resolve()
-    : new Promise((resolve) => {
+    : new Promise((resolve, reject) => {
         const stdin = process.stdin;
         const rawMode = stdin.isRaw;
         const encoding = stdin.readableEncoding || undefined;
@@ -185,19 +204,17 @@ function prestart() {
           stdin.setRawMode(rawMode);
           if (typeof key === "string" && key === "\u0003") {
             showBanner("❌ Canceled");
-            // eslint-disable-next-line local/no-process-exit
-            process.exit(1);
+            reject(1);
+          } else {
+            resolve();
           }
-          resolve(true);
         });
-        process.stdout.write(
-          `${TAG} Before continuing, make sure all emulators/simulators and Appium/Metro instances are closed.\n${TAG}\n${TAG} Press any key to continue...`
-        );
+        process.stdout.write(message);
       });
 }
 
 /**
- * Invokes `react-native run-<platform>`.
+ * Invokes `rnx-cli run --platform <platform>`.
  */
 function buildAndRun(platform: TargetPlatform) {
   switch (platform) {
@@ -229,7 +246,15 @@ async function buildRunTest({ version, platform, variant }: BuildConfig) {
     showBanner(`Build ${setup.name} [${variant}, ${engine}]`);
     await setup.prebuild(configWithEngine);
     buildAndRun(platform);
-    await test(platform, [variant, engine]);
+    if (setup.requiresManualTesting) {
+      await waitForUserInput(
+        yellow(
+          `⚠ ${setup.name} requires manual testing. When you're done, press any key to continue...`
+        )
+      );
+    } else {
+      await test(platform, [variant, engine]);
+    }
   }
 }
 
@@ -265,7 +290,7 @@ async function withReactNativeVersion(
   reset(rootDir);
 
   if (version) {
-    await setReactVersion(version, true);
+    await setReactVersion(version, false);
   } else {
     log();
   }
@@ -291,15 +316,20 @@ if (platforms.length === 0) {
   process.exitCode = 1;
   showBanner(red("No valid platforms were specified"));
 } else {
-  TEST_VARIANTS.reduce((job, variant) => {
-    return job.then(() =>
-      withReactNativeVersion(version, async () => {
-        for (const platform of platforms) {
-          await buildRunTest({ version, platform, variant });
-        }
-      })
-    );
-  }, prestart())
+  TEST_VARIANTS.reduce(
+    (job, variant) => {
+      return job.then(() =>
+        withReactNativeVersion(version, async () => {
+          for (const platform of platforms) {
+            await buildRunTest({ version, platform, variant });
+          }
+        })
+      );
+    },
+    waitForUserInput(
+      `${TAG} Before continuing, make sure all emulators/simulators and Appium/Metro instances are closed.\n${TAG}\n${TAG} Press any key to continue...`
+    )
+  )
     .then(() => {
       showBanner("Initialize new app");
       $(
@@ -337,5 +367,8 @@ if (platforms.length === 0) {
     })
     .then(() => {
       showBanner(green("✔ Pass"));
+    })
+    .catch((exitCode) => {
+      process.exitCode = exitCode ?? 1;
     });
 }