Extract to separate method

Author: Saadnajmi

ios/test_app.rb

@@ -161,25 +161,7 @@ def make_project!(xcodeproj, project_root, target_platform, options)
   FileUtils.cp_r(xcodeproj_src, destination)
   name, display_name, version, single_app = app_config(project_root)
   xcschemes_path = File.join(xcodeproj_dst, 'xcshareddata', 'xcschemes')
-
-  # Read "metalAPIValidation from the app config and apply it to the xcscheme"
-  metal_api_validation = platform_config('metalAPIValidation', project_root, target_platform)
-  puts "metalAPIValidation: #{metal_api_validation}"
-  
-  if metal_api_validation
-    xcscheme = File.join(xcschemes_path, "ReactTestApp.xcscheme")
-    puts "xcscheme: #{xcscheme}"
-    xcscheme_content = File.read(xcscheme)
-    new_content = xcscheme_content.gsub(/^\s*enableGPUValidationMode\s*=\s*"1"\s*$/, '')
-    puts "new_content: #{new_content}"
-    File.write(xcscheme, new_content)
-  end
-
-  unless name.nil?
-    FileUtils.cp(File.join(xcschemes_path, 'ReactTestApp.xcscheme'),
-                 File.join(xcschemes_path, "#{name}.xcscheme"))
-  end
-
+  configure_xcschemes!(xcschemes_path, project_root, target_platform, name)
 
   # Link source files
   %w[ReactTestApp ReactTestAppTests ReactTestAppUITests].each do |file|

ios/xcode.rb

@@ -20,3 +20,22 @@ def override_build_settings!(build_settings, overrides)
     build_settings[setting] = value
   end
 end
+
+def configure_xcschemes!(xcschemes_path, project_root, target_platform, name)
+  xcscheme = File.join(xcschemes_path, "ReactTestApp.xcscheme")
+  metal_api_validation = platform_config('metalAPIValidation', project_root, target_platform)
+
+  # Oddly enough, to disable Metal API validation, we need to remove the `enableGPUValidationMode` key from the xcscheme file.
+  # A default Xcode project does not have this key, so lets follow that pattern and only add it if it is enabled.
+  if metal_api_validation.nil? || metal_api_validation == true
+    xcscheme_content = File.read(xcscheme)
+    new_content = xcscheme_content.gsub(/^\s*enableGPUValidationMode\s*=\s*"1"\s*$/, '')
+    File.write(xcscheme, new_content)
+    return
+  end
+
+  # Make a copy of the ReactTestApp.xcscheme file with the app name for convenience.
+  unless name.nil?
+    FileUtils.cp(xcscheme, File.join(xcschemes_path, "#{name}.xcscheme"))
+  end
+end