fix(android): fix crash when initial props is set (#1206)

Author: tido64

android/app/src/main/java/com/microsoft/reacttestapp/TestApp.kt

@@ -5,6 +5,7 @@ import android.app.Application
 import android.content.Context
 import com.facebook.react.PackageList
 import com.facebook.react.ReactApplication
+import com.facebook.soloader.SoLoader
 import com.microsoft.reacttestapp.manifest.ManifestProvider
 import com.microsoft.reacttestapp.react.ReactBundleNameProvider
 import com.microsoft.reacttestapp.react.TestAppReactNativeHost
@@ -25,6 +26,10 @@ class TestApp : Application(), ReactApplication {
     override fun onCreate() {
         super.onCreate()
 
+        // We need to initialize SoLoader early because ManifestProvider may
+        // need to use WritableNativeMap when parsing initial properties.
+        SoLoader.init(this, false)
+
         manifestProviderInternal = ManifestProvider.create(this)
         val (manifest, _) = manifestProvider.fromResources()
 

android/app/src/main/java/com/microsoft/reacttestapp/react/TestAppReactNativeHost.kt

@@ -85,7 +85,6 @@ class TestAppReactNativeHost(
         reactInstanceManager.addReactInstanceEventListener(reactInstanceListener)
 
         beforeReactNativeInit()
-        SoLoader.init(application, false)
         reactInstanceManager.createReactContextInBackground()
 
         if (BuildConfig.DEBUG) {