[Fabric] Add DeviceInfoModule (#12450)

marlenecota · web-flow · commit 04329dceb555 · 2023-12-05T13:26:35.000-08:00
* First pass at Fabric DeviceInfo

* remove DeviceInfoModule stub

* Change files

* formatting

* ForwardWindowMessage

* limit ForwardWindowMessage to WM_WINDOWPOSCHANGED

* formatting

* First pass at Fabric DeviceInfo

* remove DeviceInfoModule stub

* Change files

* formatting

* ForwardWindowMessage

* limit ForwardWindowMessage to WM_WINDOWPOSCHANGED

* formatting

* gatekeep InitDeviceInfoHolder
diff --git a/change/react-native-windows-7e664452-5ed5-4193-950e-859b8171d325.json b/change/react-native-windows-7e664452-5ed5-4193-950e-859b8171d325.json
@@ -0,0 +1,7 @@
+{
+  "type": "prerelease",
+  "comment": "[Fabric] Add DeviceInfoModule",
+  "packageName": "react-native-windows",
+  "email": "email not defined",
+  "dependentChangeType": "patch"
+}
diff --git a/packages/playground/windows/playground-composition/DeviceInfoModule.cpp b/packages/playground/windows/playground-composition/DeviceInfoModule.cpp
diff --git a/packages/playground/windows/playground-composition/Playground-Composition.cpp b/packages/playground/windows/playground-composition/Playground-Composition.cpp
@@ -22,6 +22,7 @@
 #include <winrt/Windows.UI.Composition.Desktop.h>
 #include <winrt/Windows.UI.Composition.h>
 
+#include <DesktopWindowBridge.h>
 #include "NativeModules.h"
 #include "ReactPropertyBag.h"
 
@@ -153,7 +154,6 @@ struct WindowData {
               std::wstring(L"file:").append(workingDir).append(L"\\Bundle\\").c_str());
           host.InstanceSettings().UseDeveloperSupport(true);
 
-          host.PackageProviders().Append(CreateStubDeviceInfoPackageProvider());
           host.PackageProviders().Append(winrt::make<CompReactPackageProvider>());
           winrt::Microsoft::ReactNative::ReactCoreInjection::SetTopLevelWindowId(
               host.InstanceSettings().Properties(), reinterpret_cast<uint64_t>(hwnd));
@@ -480,6 +480,9 @@ LRESULT CALLBACK WndProc(HWND hwnd, UINT message, WPARAM wparam, LPARAM lparam)
     case WM_WINDOWPOSCHANGED: {
       auto windowData = WindowData::GetFromWindow(hwnd);
       windowData->UpdateSize(hwnd);
+
+      winrt::Microsoft::ReactNative::ReactNotificationService rns(windowData->InstanceSettings().Notifications());
+      winrt::Microsoft::ReactNative::ForwardWindowMessage(rns, hwnd, message, wparam, lparam);
       break;
     }
   }
diff --git a/packages/playground/windows/playground-composition/Playground-Composition.vcxproj b/packages/playground/windows/playground-composition/Playground-Composition.vcxproj
@@ -116,7 +116,6 @@
       <PrecompiledHeader>Create</PrecompiledHeader>
     </ClCompile>
     <ClCompile Include="CustomComponent.cpp" />
-    <ClCompile Include="DeviceInfoModule.cpp" />
     <ClCompile Include="Playground-Composition.cpp" />
   </ItemGroup>
   <ItemGroup>
diff --git a/vnext/Microsoft.ReactNative/Modules/DeviceInfoModule.cpp b/vnext/Microsoft.ReactNative/Modules/DeviceInfoModule.cpp
@@ -16,6 +16,10 @@
 #include <winrt/Windows.UI.Core.h>
 #include <winrt/Windows.UI.ViewManagement.h>
 
+#ifdef USE_FABRIC
+#include <ReactCoreInjection.h>
+#endif
+
 using namespace winrt::Microsoft::ReactNative;
 
 namespace Microsoft::ReactNative {
@@ -32,42 +36,54 @@ DeviceInfoHolder::DeviceInfoHolder(const Mso::React::IReactContext &context) : m
 }
 
 void DeviceInfoHolder::InitDeviceInfoHolder(const Mso::React::IReactContext &context) noexcept {
-  if (xaml::TryGetCurrentApplication()) {
+  if (xaml::TryGetCurrentApplication() || IsFabricEnabled(context.Properties())) {
     auto deviceInfoHolder = std::make_shared<DeviceInfoHolder>(context);
 
     deviceInfoHolder->updateDeviceInfo();
     winrt::Microsoft::ReactNative::ReactPropertyBag pb{context.Properties()};
     pb.Set(DeviceInfoHolderPropertyId(), std::move(deviceInfoHolder));
 
-    if (auto window = xaml::Window::Current()) {
-      auto const &coreWindow = window.CoreWindow();
+    uint64_t hwnd = 0;
 
-      deviceInfoHolder->m_sizeChangedRevoker =
-          coreWindow.SizeChanged(winrt::auto_revoke, [weakHolder = std::weak_ptr(deviceInfoHolder)](auto &&, auto &&) {
-            if (auto strongHolder = weakHolder.lock()) {
-              strongHolder->updateDeviceInfo();
-            }
-          });
-    } else {
-      assert(IsXamlIsland());
-      // This is either a WinUI 3 island or a system XAML island
-      // system XAML islands have a CoreWindow so we want to use the GetForCurrentView APIs
-      // For WinUI 3 islands we require the app to forward window messages as ReactNotifications
+#ifdef USE_FABRIC
+    if (IsFabricEnabled(context.Properties())) {
+      hwnd = winrt::Microsoft::ReactNative::implementation::ReactCoreInjection::GetTopLevelWindowId(pb.Handle());
     }
+#endif
 
-    if (!IsWinUI3Island()) {
-      // UWP or system XAML island
-      auto const &displayInfo = winrt::Windows::Graphics::Display::DisplayInformation::GetForCurrentView();
+    if (xaml::TryGetCurrentApplication()) {
+      if (auto window = xaml::Window::Current()) {
+        auto const &coreWindow = window.CoreWindow();
 
-      deviceInfoHolder->m_dpiChangedRevoker = displayInfo.DpiChanged(
-          winrt::auto_revoke, [weakHolder = std::weak_ptr(deviceInfoHolder)](const auto &, const auto &) {
-            if (auto strongHolder = weakHolder.lock()) {
-              strongHolder->updateDeviceInfo();
-            }
-          });
-    } else if (
-        auto hwnd =
-            reinterpret_cast<HWND>(XamlUIService::GetIslandWindowHandle(deviceInfoHolder->m_context->Properties()))) {
+        deviceInfoHolder->m_sizeChangedRevoker = coreWindow.SizeChanged(
+            winrt::auto_revoke, [weakHolder = std::weak_ptr(deviceInfoHolder)](auto &&, auto &&) {
+              if (auto strongHolder = weakHolder.lock()) {
+                strongHolder->updateDeviceInfo();
+              }
+            });
+      } else {
+        assert(IsXamlIsland());
+        // This is either a WinUI 3 island or a system XAML island
+        // system XAML islands have a CoreWindow so we want to use the GetForCurrentView APIs
+        // For WinUI 3 islands we require the app to forward window messages as ReactNotifications
+      }
+
+      if (!IsWinUI3Island()) {
+        // UWP or system XAML island
+        auto const &displayInfo = winrt::Windows::Graphics::Display::DisplayInformation::GetForCurrentView();
+
+        deviceInfoHolder->m_dpiChangedRevoker = displayInfo.DpiChanged(
+            winrt::auto_revoke, [weakHolder = std::weak_ptr(deviceInfoHolder)](const auto &, const auto &) {
+              if (auto strongHolder = weakHolder.lock()) {
+                strongHolder->updateDeviceInfo();
+              }
+            });
+      } else {
+        hwnd = XamlUIService::GetIslandWindowHandle(deviceInfoHolder->m_context->Properties());
+      }
+    }
+
+    if (hwnd) {
       deviceInfoHolder->m_wmSubscription = SubscribeToWindowMessage(
           ReactNotificationService(context.Notifications()),
           WM_WINDOWPOSCHANGED,
@@ -146,11 +162,22 @@ void DeviceInfoHolder::updateDeviceInfo() noexcept {
 
     m_windowWidth = window.Bounds().Width;
     m_windowHeight = window.Bounds().Height;
-  } else if (auto hwnd = reinterpret_cast<HWND>(XamlUIService::GetIslandWindowHandle(m_context->Properties()))) {
-    RECT rect{};
-    if (CALL_INDIRECT(L"user32.dll", GetWindowRect, hwnd, &rect)) {
-      m_windowWidth = (float)(rect.right - rect.left);
-      m_windowHeight = (float)(rect.bottom - rect.top);
+  } else {
+    auto hwnd = XamlUIService::GetIslandWindowHandle(m_context->Properties());
+
+#ifdef USE_FABRIC
+    if (IsFabricEnabled(m_context->Properties())) {
+      winrt::Microsoft::ReactNative::ReactPropertyBag pb{m_context->Properties()};
+      hwnd = winrt::Microsoft::ReactNative::implementation::ReactCoreInjection::GetTopLevelWindowId(pb.Handle());
+    }
+#endif
+
+    if (hwnd) {
+      RECT rect{};
+      if (CALL_INDIRECT(L"user32.dll", GetWindowRect, reinterpret_cast<HWND>(hwnd), &rect)) {
+        m_windowWidth = (float)(rect.right - rect.left);
+        m_windowHeight = (float)(rect.bottom - rect.top);
+      }
     }
   }
 
@@ -165,14 +192,20 @@ void DeviceInfoHolder::updateDeviceInfo() noexcept {
     notifyChanged();
   } else {
     RECT desktopRect{};
-    if (CALL_INDIRECT(L"user32.dll", GetWindowRect, nullptr, &desktopRect)) {
+
+    auto hwnd = XamlUIService::GetIslandWindowHandle(m_context->Properties());
+
+#ifdef USE_FABRIC
+    if (IsFabricEnabled(m_context->Properties())) {
+      winrt::Microsoft::ReactNative::ReactPropertyBag pb{m_context->Properties()};
+      hwnd = winrt::Microsoft::ReactNative::implementation::ReactCoreInjection::GetTopLevelWindowId(pb.Handle());
+    }
+#endif
+
+    if (hwnd && CALL_INDIRECT(L"user32.dll", GetWindowRect, reinterpret_cast<HWND>(hwnd), &desktopRect)) {
       m_screenWidth = static_cast<uint32_t>(desktopRect.right - desktopRect.left);
       m_screenHeight = static_cast<uint32_t>(desktopRect.bottom - desktopRect.top);
-      m_dpi = static_cast<float>(CALL_INDIRECT(
-          L"user32.dll",
-          GetDpiForWindow,
-          reinterpret_cast<HWND>(
-              winrt::Microsoft::ReactNative::XamlUIService::GetIslandWindowHandle(m_context->Properties()))));
+      m_dpi = static_cast<float>(CALL_INDIRECT(L"user32.dll", GetDpiForWindow, reinterpret_cast<HWND>(hwnd)));
     }
   }
 }
