Skip to content

Commit 80688a3

Browse files
authored
Rework EventPhase type to avoid using TS enum (#12908)
* Rework EventPhase type to avoid using TS enum * Change files
1 parent 69b701f commit 80688a3

File tree

2 files changed

+21
-10
lines changed

2 files changed

+21
-10
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "prerelease",
3+
"comment": "Rework EventPhase type to avoid using TS enum",
4+
"packageName": "react-native-windows",
5+
"email": "[email protected]",
6+
"dependentChangeType": "patch"
7+
}

vnext/src-win/Libraries/Components/View/ViewPropTypes.d.ts

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -167,16 +167,16 @@ export interface ViewPropsAndroid {
167167

168168
// [Windows
169169

170-
export enum EventPhase {
171-
None = 0,
172-
Capturing,
173-
AtTarget,
174-
Bubbling,
170+
export namespace EventPhase {
171+
export const None = 0;
172+
export const Capturing = 1;
173+
export const AtTarget = 2;
174+
export const Bubbling = 3;
175175
}
176176

177-
export enum HandledEventPhase {
178-
Capturing = EventPhase.Capturing,
179-
Bubbling = EventPhase.Bubbling,
177+
export namespace HandledEventPhase {
178+
const Capturing = EventPhase.Capturing;
179+
const Bubbling = EventPhase.Bubbling;
180180
}
181181

182182
export interface INativeKeyboardEvent {
@@ -186,7 +186,11 @@ export interface INativeKeyboardEvent {
186186
shiftKey: boolean;
187187
key: string;
188188
code: string;
189-
eventPhase: EventPhase;
189+
eventPhase:
190+
| EventPhase.None
191+
| EventPhase.Capturing
192+
| EventPhase.AtTarget
193+
| EventPhase.Bubbling;
190194
}
191195

192196
export interface IHandledKeyboardEvent {
@@ -195,7 +199,7 @@ export interface IHandledKeyboardEvent {
195199
metaKey?: boolean;
196200
shiftKey?: boolean;
197201
code: string;
198-
handledEventPhase?: HandledEventPhase;
202+
handledEventPhase?: EventPhase.Capturing | EventPhase.Bubbling;
199203
}
200204

201205
export type IKeyboardEvent = NativeSyntheticEvent<INativeKeyboardEvent>;

0 commit comments

Comments
 (0)