Skip to content

Commit a948daf

Browse files
authored
Unfork and modularize Yoga (#12591)
* Unfork Yoga * Change files * Remove yoga.cpp from react-native-platform-override e2etests * Update comment reference * Revert "Remove yoga.cpp from react-native-platform-override e2etests" This reverts commit a4dbd44. * re-add yoga to fake overrides.json * remove react-native-platform-override change file
1 parent 7939ac3 commit a948daf

File tree

6 files changed

+26
-955
lines changed

6 files changed

+26
-955
lines changed

.cspell.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,7 @@
1919
"packages/@react-native-windows/tester",
2020
"packages/react-native-platform-override/src/e2etest/collateral",
2121
"vnext/Folly/TEMP_UntilFollyUpdate",
22-
"vnext/ReactCommon/TEMP_UntilReactCommonUpdate",
23-
"vnext/ReactCommon/Yoga.cpp"
22+
"vnext/ReactCommon/TEMP_UntilReactCommonUpdate"
2423
],
2524
"useGitignore": true,
2625
"ignoreRegExpList": [
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "prerelease",
3+
"comment": "Unfork Yoga",
4+
"packageName": "react-native-windows",
5+
"email": "email not defined",
6+
"dependentChangeType": "patch"
7+
}

vnext/Microsoft.ReactNative/Modules/NativeUIManager.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ NativeUIManager::NativeUIManager(winrt::Microsoft::ReactNative::ReactContext con
163163
// To Debug Yoga layout, uncomment the following line.
164164
// YGConfigSetPrintTreeFlag(m_yogaConfig, true);
165165

166-
// Additional logging can be enabled editing yoga.cpp (e.g. gPrintChanges,
166+
// Additional logging can be enabled editing CalculateLayout.cpp (e.g. gPrintChanges,
167167
// gPrintSkips)
168168
#endif
169169
}

vnext/ReactCommon/ReactCommon.vcxproj

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,12 @@
131131
<ClCompile Include="$(ReactNativeDir)\ReactCommon\jsinspector-modern\InspectorInterfaces.cpp" />
132132
<ClCompile Include="$(ReactNativeDir)\ReactCommon\logger\react_native_log.cpp" />
133133
<CLCompile Include="$(ReactNativeDir)\ReactCommon\reactperflogger\reactperflogger\BridgeNativeModulePerfLogger.cpp" />
134+
<ClCompile Include="$(YogaDir)\yoga\YGConfig.cpp" />
134135
<ClCompile Include="$(YogaDir)\yoga\YGEnums.cpp" />
136+
<ClCompile Include="$(YogaDir)\yoga\YGNode.cpp" />
137+
<ClCompile Include="$(YogaDir)\yoga\YGNodeLayout.cpp" />
138+
<ClCompile Include="$(YogaDir)\yoga\YGNodeStyle.cpp" />
139+
<ClCompile Include="$(YogaDir)\yoga\YGPixelGrid.cpp" />
135140
<ClCompile Include="$(YogaDir)\yoga\YGValue.cpp" />
136141
<ClCompile Include="$(YogaDir)\yoga\algorithm\Baseline.cpp" />
137142
<ClCompile Include="$(YogaDir)\yoga\algorithm\Cache.cpp" />
@@ -150,10 +155,6 @@
150155
<ClCompile Include="$(ReactNativeDir)\ReactCommon\react\renderer\mapbuffer\MapBuffer.cpp" />
151156
<ClCompile Include="$(ReactNativeDir)\ReactCommon\react\renderer\mapbuffer\MapBufferBuilder.cpp" />
152157
<ClCompile Include="$(ReactNativeDir)\ReactCommon\react\renderer\telemetry\TransactionTelemetry.cpp" />
153-
<!--
154-
Using a patched copy of Yoga due to https://github.com/microsoft/react-native-windows/issues/3994
155-
-->
156-
<ClCompile Include="Yoga.cpp" AdditionalIncludeDirectories="$(YogaDir)\yoga;%(AdditionalIncludeDirectories)" />
157158
<ClCompile Include="$(YogaDir)\yoga\event\event.cpp" />
158159
<ClCompile Include="pch.cpp">
159160
<PrecompiledHeader>Create</PrecompiledHeader>

vnext/ReactCommon/ReactCommon.vcxproj.filters

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,9 @@
120120
<ClCompile Include="$(YogaDir)\yoga\Utils.cpp">
121121
<Filter>yoga</Filter>
122122
</ClCompile>
123+
<ClCompile Include="$(YogaDir)\yoga\YGConfig.cpp">
124+
<Filter>yoga</Filter>
125+
</ClCompile>
123126
<ClCompile Include="$(YogaDir)\yoga\YGEnums.cpp">
124127
<Filter>yoga</Filter>
125128
</ClCompile>
@@ -129,9 +132,18 @@
129132
<ClCompile Include="$(YogaDir)\yoga\YGNode.cpp">
130133
<Filter>yoga</Filter>
131134
</ClCompile>
135+
<ClCompile Include="$(YogaDir)\yoga\YGNodeLayout.cpp">
136+
<Filter>yoga</Filter>
137+
</ClCompile>
138+
<ClCompile Include="$(YogaDir)\yoga\YGNodeStyle.cpp">
139+
<Filter>yoga</Filter>
140+
</ClCompile>
132141
<ClCompile Include="$(YogaDir)\yoga\YGNodePrint.cpp">
133142
<Filter>yoga</Filter>
134143
</ClCompile>
144+
<ClCompile Include="$(YogaDir)\yoga\YGPixelGrid.cpp">
145+
<Filter>yoga</Filter>
146+
</ClCompile>
135147
<ClCompile Include="$(ReactNativeDir)\ReactCommon\jsi\jsi\jsi.cpp">
136148
<Filter>jsi\jsi</Filter>
137149
</ClCompile>
@@ -175,7 +187,6 @@
175187
<Filter>react\renderer\debug</Filter>
176188
</ClCompile>
177189
<ClCompile Include="pch.cpp" />
178-
<ClCompile Include="Yoga.cpp" />
179190
<ClCompile Include="$(ReactNativeDir)\ReactCommon\logger\react_native_log.cpp">
180191
<Filter>logger</Filter>
181192
</ClCompile>

0 commit comments

Comments
 (0)