Merge branch 'main' into nitinc/fix-tooltip-positioning-on-scroll

Author: Nitin-100

change/react-native-windows-49284bd6-2b6c-4cc5-8124-9ba345612623.json

@@ -0,0 +1,7 @@
+{
+  "type": "none",
+  "comment": "fix getSize",
+  "packageName": "react-native-windows",
+  "email": "hmalothu@microsoft.com",
+  "dependentChangeType": "none"
+}

vnext/Microsoft.ReactNative/Modules/ImageViewManagerModule.cpp

@@ -24,15 +24,28 @@ using namespace Windows::Storage::Streams;
 
 namespace Microsoft::ReactNative {
 
+static const char *ERROR_INVALID_URI = "E_INVALID_URI";
+static const char *ERROR_GET_SIZE_FAILURE = "E_GET_SIZE_FAILURE";
+
 winrt::fire_and_forget GetImageSizeAsync(
     const winrt::Microsoft::ReactNative::IReactPropertyBag &properties,
     std::string uriString,
     winrt::Microsoft::ReactNative::JSValue &&headers,
     Mso::Functor<void(int32_t width, int32_t height)> successCallback,
-    Mso::Functor<void()> errorCallback) {
+    Mso::Functor<void(const char *errorCode, std::string errorMessage)> errorCallback) {
   bool succeeded{false};
+  const char *errorCode = ERROR_GET_SIZE_FAILURE;
+  std::string errorMessage;
 
   try {
+    // Validate URI is not empty
+    if (uriString.empty()) {
+      errorCode = ERROR_INVALID_URI;
+      errorMessage = "Cannot get the size of an image for an empty URI";
+      errorCallback(errorCode, errorMessage);
+      co_return;
+    }
+
     ReactImageSource source;
     source.uri = uriString;
     if (!headers.IsNull()) {
@@ -45,28 +58,38 @@ winrt::fire_and_forget GetImageSizeAsync(
     winrt::hstring scheme{uri.SchemeName()};
     bool needsDownload = (scheme == L"http") || (scheme == L"https");
     bool inlineData = scheme == L"data";
+    bool isLocalFile = (scheme == L"file") || (scheme == L"ms-appx") || (scheme == L"ms-appdata");
 
     winrt::IRandomAccessStream memoryStream;
-    if (needsDownload) {
+    if (needsDownload || isLocalFile) {
       memoryStream = co_await GetImageStreamAsync(properties, source);
     } else if (inlineData) {
       memoryStream = co_await GetImageInlineDataAsync(source);
     }
-    auto result = wicBitmapSourceFromStream(memoryStream);
-    if (!std::get<std::shared_ptr<facebook::react::ImageErrorInfo>>(result)) {
-      auto imagingFactory = std::get<winrt::com_ptr<IWICImagingFactory>>(result);
-      auto wicBmpSource = std::get<winrt::com_ptr<IWICBitmapSource>>(result);
-      UINT width, height;
-      if (SUCCEEDED(wicBmpSource->GetSize(&width, &height))) {
-        successCallback(width, height);
-        succeeded = true;
+
+    if (memoryStream) {
+      auto result = wicBitmapSourceFromStream(memoryStream);
+      if (!std::get<std::shared_ptr<facebook::react::ImageErrorInfo>>(result)) {
+        auto imagingFactory = std::get<winrt::com_ptr<IWICImagingFactory>>(result);
+        auto wicBmpSource = std::get<winrt::com_ptr<IWICBitmapSource>>(result);
+        UINT width, height;
+        if (SUCCEEDED(wicBmpSource->GetSize(&width, &height))) {
+          successCallback(width, height);
+          succeeded = true;
+        }
       }
     }
-  } catch (winrt::hresult_error const &) {
+  } catch (winrt::hresult_error const &e) {
+    errorMessage = "Failed to get image size: " + Microsoft::Common::Unicode::Utf16ToUtf8(std::wstring(e.message())) +
+        " for URI: " + uriString;
   }
 
-  if (!succeeded)
-    errorCallback();
+  if (!succeeded) {
+    if (errorMessage.empty()) {
+      errorMessage = "Failed to get image size for URI: " + uriString;
+    }
+    errorCallback(errorCode, errorMessage);
+  }
 
   co_return;
 }
@@ -85,7 +108,9 @@ void ImageLoader::getSize(std::string uri, React::ReactPromise<std::vector<doubl
             [result](double width, double height) noexcept {
               result.Resolve(std::vector<double>{width, height});
             },
-            [result]() noexcept { result.Reject("Failed"); });
+            [result](const char *errorCode, std::string errorMessage) noexcept {
+              result.Reject(React::ReactError{errorCode, errorMessage});
+            });
       });
 }
 
@@ -105,7 +130,9 @@ void ImageLoader::getSizeWithHeaders(
         [result](double width, double height) noexcept {
           result.Resolve(Microsoft::ReactNativeSpecs::ImageLoaderIOSSpec_getSizeWithHeaders_returnType{width, height});
         },
-        [result]() noexcept { result.Reject("Failed"); });
+        [result](const char *errorCode, std::string errorMessage) noexcept {
+          result.Reject(React::ReactError{errorCode, errorMessage});
+        });
   });
 }
 
@@ -130,4 +157,4 @@ void ImageLoader::queryCache(
   result.Resolve(React::JSValueObject{});
 }
 
-} // namespace Microsoft::ReactNative
+} // namespace Microsoft::ReactNative