JSI might throw non-hresult exceptions

asklar · asklar · commit cd816d48a4c7 · 2022-02-19T23:34:32.000-08:00
diff --git a/package/windows/ReactNativeXaml/XamlObject.cpp b/package/windows/ReactNativeXaml/XamlObject.cpp
@@ -159,11 +159,15 @@ jsi::Value XamlObject::get(jsi::Runtime& rt, const jsi::PropNameID& nameId) noex
         });
       return IInspectableToValue(rt, res);
     }
+
   }
-  catch (const winrt::hresult& hr) {
-    OutputDebugStringA(std::to_string(hr.value).c_str());
+  catch (const std::exception& exc) {
+    OutputDebugStringA(__FUNCTION__);
+    OutputDebugStringA(": ");
+    OutputDebugStringA(exc.what());
     OutputDebugStringA("\n");
   }
+
   return jsi::HostObject::get(rt, nameId);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -159,11 +159,15 @@ jsi::Value XamlObject::get(jsi::Runtime& rt, const jsi::PropNameID& nameId) noex`
`159`	`159`	`});`
`160`	`160`	`return IInspectableToValue(rt, res);`
`161`	`161`	`}`
	`162`	`+`
`162`	`163`	`}`
`163`		`- catch (const winrt::hresult& hr) {`
`164`		`- OutputDebugStringA(std::to_string(hr.value).c_str());`
	`164`	`+ catch (const std::exception& exc) {`
	`165`	`+ OutputDebugStringA(__FUNCTION__);`
	`166`	`+ OutputDebugStringA(": ");`
	`167`	`+ OutputDebugStringA(exc.what());`
`165`	`168`	`OutputDebugStringA("\n");`
`166`	`169`	`}`
	`170`	`+`
`167`	`171`	`return jsi::HostObject::get(rt, nameId);`
`168`	`172`	`}`
`169`	`173`