Skip to content

Commit f51e00f

Browse files
authored
Patch to 9.35.1 (#3138)
* Revert "Improve handleParagraph function (#3130)" (#3137) This reverts commit 9f8abbf. * upgrade to 9.35.1
1 parent 1878d7a commit f51e00f

File tree

4 files changed

+14
-29
lines changed

4 files changed

+14
-29
lines changed

packages/roosterjs-content-model-core/lib/coreApi/setContentModel/setContentModel.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ export const setContentModel: SetContentModel = (
4141
core.onFixUpModel?.(model);
4242

4343
const selection = contentModelToDom(
44-
core.logicalRoot.ownerDocument.implementation.createHTMLDocument(),
44+
core.logicalRoot.ownerDocument,
4545
core.logicalRoot,
4646
model,
4747
modelToDomContext

packages/roosterjs-content-model-core/test/coreApi/setContentModel/setContentModelTest.ts

Lines changed: 9 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,11 @@ import * as updateCache from '../../../lib/corePlugin/cache/updateCache';
44
import { ContentModelDocument, EditorCore, ModelToDomContext } from 'roosterjs-content-model-types';
55
import { setContentModel } from '../../../lib/coreApi/setContentModel/setContentModel';
66

7+
const mockedDoc = 'DOCUMENT' as any;
78
const mockedModel = 'MODEL' as any;
89
const mockedEditorContext = 'EDITORCONTEXT' as any;
910
const mockedContext = { name: 'CONTEXT', rewriteFromModel: {} } as any;
11+
const mockedDiv = { ownerDocument: mockedDoc } as any;
1012
const mockedConfig = 'CONFIG' as any;
1113

1214
describe('setContentModel', () => {
@@ -20,19 +22,8 @@ describe('setContentModel', () => {
2022
let flushMutationsSpy: jasmine.Spy;
2123
let updateCacheSpy: jasmine.Spy;
2224
let triggerEventSpy: jasmine.Spy;
23-
let mockedDiv: HTMLElement;
24-
let doc: Document;
2525

2626
beforeEach(() => {
27-
doc = document.implementation.createHTMLDocument('test');
28-
29-
mockedDiv = {
30-
ownerDocument: {
31-
implementation: {
32-
createHTMLDocument: () => doc,
33-
},
34-
},
35-
} as any;
3627
contentModelToDomSpy = spyOn(contentModelToDom, 'contentModelToDom');
3728
createEditorContext = jasmine
3829
.createSpy('createEditorContext')
@@ -88,7 +79,7 @@ describe('setContentModel', () => {
8879
mockedEditorContext
8980
);
9081
expect(contentModelToDomSpy).toHaveBeenCalledWith(
91-
jasmine.anything(),
82+
mockedDoc,
9283
mockedDiv,
9384
mockedModel,
9485
mockedContext
@@ -112,7 +103,7 @@ describe('setContentModel', () => {
112103
mockedEditorContext
113104
);
114105
expect(contentModelToDomSpy).toHaveBeenCalledWith(
115-
doc,
106+
mockedDoc,
116107
mockedDiv,
117108
mockedModel,
118109
mockedContext
@@ -142,7 +133,7 @@ describe('setContentModel', () => {
142133
additionalOption
143134
);
144135
expect(contentModelToDomSpy).toHaveBeenCalledWith(
145-
doc,
136+
mockedDoc,
146137
mockedDiv,
147138
mockedModel,
148139
mockedContext
@@ -167,7 +158,7 @@ describe('setContentModel', () => {
167158
mockedEditorContext
168159
);
169160
expect(contentModelToDomSpy).toHaveBeenCalledWith(
170-
doc,
161+
mockedDoc,
171162
mockedDiv,
172163
mockedModel,
173164
mockedContext
@@ -199,7 +190,7 @@ describe('setContentModel', () => {
199190
}
200191
);
201192
expect(contentModelToDomSpy).toHaveBeenCalledWith(
202-
doc,
193+
mockedDoc,
203194
mockedDiv,
204195
mockedModel,
205196
mockedContext
@@ -233,7 +224,7 @@ describe('setContentModel', () => {
233224
}
234225
);
235226
expect(contentModelToDomSpy).toHaveBeenCalledWith(
236-
doc,
227+
mockedDoc,
237228
mockedDiv,
238229
mockedModel,
239230
mockedContext
@@ -262,7 +253,7 @@ describe('setContentModel', () => {
262253
}
263254
);
264255
expect(contentModelToDomSpy).toHaveBeenCalledWith(
265-
doc,
256+
mockedDoc,
266257
mockedDiv,
267258
mockedModel,
268259
mockedContext

packages/roosterjs-content-model-dom/lib/modelToDom/handlers/handleParagraph.ts

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,11 @@ export const handleParagraph: ContentModelBlockHandler<ContentModelParagraph> =
3939
...paragraph.segmentFormat,
4040
}
4141
: {};
42-
const prevRefNode = refNode?.previousSibling;
4342

4443
container = doc.createElement(paragraph.decorator?.tagName || DefaultParagraphTag);
4544

45+
parent.insertBefore(container, refNode);
46+
4647
context.regularSelection.current = {
4748
block: needParagraphWrapper ? container : container.parentNode,
4849
segment: null,
@@ -107,14 +108,7 @@ export const handleParagraph: ContentModelBlockHandler<ContentModelParagraph> =
107108
// since this paragraph it is implicit. In that case container.nextSibling will become original
108109
// inline entity's next sibling. So reset refNode to its real next sibling (after change) here
109110
// to make sure the value is correct.
110-
refNode =
111-
prevRefNode === undefined // When refNode is not passed in
112-
? null
113-
: prevRefNode === null // When refNode is the first child of parent
114-
? parent.firstChild
115-
: prevRefNode.nextSibling; // Normal case
116-
117-
parent.insertBefore(container, refNode);
111+
refNode = container.nextSibling;
118112

119113
if (container) {
120114
context.onNodeCreated?.(paragraph, container);

versions.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"react": "9.0.2",
3-
"main": "9.35.0",
3+
"main": "9.35.1",
44
"legacyAdapter": "8.65.0",
55
"overrides": {}
66
}

0 commit comments

Comments
 (0)