[ts-command-line] Remove deprecations and perform updates planned for the next major bump. (#5203)

* Remove deprecated functions.

* Renames.

* fixup! Remove deprecated functions.

* fixup! Remove deprecated functions.

* fixup! Remove deprecated functions.

Author: iclanton

apps/api-documenter/src/cli/BaseAction.ts

@@ -32,7 +32,6 @@ export abstract class BaseAction extends CommandLineAction {
   protected constructor(options: ICommandLineActionOptions) {
     super(options);
 
-    // override
     this._inputFolderParameter = this.defineStringParameter({
       parameterLongName: '--input-folder',
       parameterShortName: '-i',

apps/api-documenter/src/cli/GenerateAction.ts

@@ -22,8 +22,7 @@ export class GenerateAction extends BaseAction {
     });
   }
 
-  protected async onExecute(): Promise<void> {
-    // override
+  protected override async onExecuteAsync(): Promise<void> {
     // Look for the config file under the current folder
 
     let configFilePath: string = path.join(process.cwd(), DocumenterConfig.FILENAME);

apps/api-documenter/src/cli/MarkdownAction.ts

@@ -16,8 +16,7 @@ export class MarkdownAction extends BaseAction {
     });
   }
 
-  protected async onExecute(): Promise<void> {
-    // override
+  protected override async onExecuteAsync(): Promise<void> {
     const { apiModel, outputFolder } = this.buildApiModel();
 
     const markdownDocumenter: MarkdownDocumenter = new MarkdownDocumenter({

apps/api-documenter/src/cli/YamlAction.ts

@@ -50,8 +50,7 @@ export class YamlAction extends BaseAction {
     });
   }
 
-  protected async onExecute(): Promise<void> {
-    // override
+  protected override async onExecuteAsync(): Promise<void> {
     const { apiModel, inputFolder, outputFolder } = this.buildApiModel();
 
     const yamlDocumenter: YamlDocumenter = this._officeParameter.value

apps/api-documenter/src/documenters/OfficeYamlDocumenter.ts

@@ -65,7 +65,6 @@ export class OfficeYamlDocumenter extends YamlDocumenter {
 
   /** @override */
   protected onGetTocRoot(): IYamlTocItem {
-    // override
     return {
       name: 'API reference',
       href: 'overview.md',

apps/api-extractor/src/cli/ApiExtractorCommandLine.ts

@@ -32,21 +32,22 @@ export class ApiExtractorCommandLine extends CommandLineParser {
     });
   }
 
-  protected onExecute(): Promise<void> {
-    // override
+  protected override async onExecuteAsync(): Promise<void> {
     if (this._debugParameter.value) {
       InternalError.breakInDebugger = true;
     }
 
-    return super.onExecute().catch((error) => {
+    process.exitCode = 1;
+    try {
+      await super.onExecuteAsync();
+      process.exitCode = 0;
+    } catch (error) {
       if (this._debugParameter.value) {
         console.error(os.EOL + error.stack);
       } else {
         console.error(os.EOL + Colorize.red('ERROR: ' + error.message.trim()));
       }
-
-      process.exitCode = 1;
-    });
+    }
   }
 
   private _populateActions(): void {

apps/api-extractor/src/cli/InitAction.ts

@@ -21,8 +21,7 @@ export class InitAction extends CommandLineAction {
     });
   }
 
-  protected async onExecute(): Promise<void> {
-    // override
+  protected override async onExecuteAsync(): Promise<void> {
     const inputFilePath: string = path.resolve(__dirname, '../schemas/api-extractor-template.json');
     const outputFilePath: string = path.resolve(ExtractorConfig.FILENAME);
 

apps/api-extractor/src/cli/RunAction.ts

@@ -71,8 +71,7 @@ export class RunAction extends CommandLineAction {
     });
   }
 
-  protected async onExecute(): Promise<void> {
-    // override
+  protected override async onExecuteAsync(): Promise<void> {
     const lookup: PackageJsonLookup = new PackageJsonLookup();
     let configFilename: string;
 

apps/cpu-profile-summarizer/src/start.ts

@@ -147,7 +147,7 @@ class CpuProfileSummarizerCommandLineParser extends CommandLineParser {
     });
   }
 
-  protected async onExecute(): Promise<void> {
+  protected override async onExecuteAsync(): Promise<void> {
     const input: readonly string[] = this._inputParameter.values;
     const output: string = this._outputParameter.value;
 

apps/heft/src/cli/HeftCommandLineParser.ts

@@ -176,7 +176,7 @@ export class HeftCommandLineParser extends CommandLineParser {
     }
   }
 
-  protected async onExecute(): Promise<void> {
+  protected override async onExecuteAsync(): Promise<void> {
     try {
       const selectedAction: CommandLineAction | undefined = this.selectedAction;
 
@@ -196,7 +196,7 @@ export class HeftCommandLineParser extends CommandLineParser {
         commandName,
         unaliasedCommandName
       };
-      await super.onExecute();
+      await super.onExecuteAsync();
     } catch (e) {
       await this._reportErrorAndSetExitCodeAsync(e as Error);
     }
@@ -228,7 +228,7 @@ export class HeftCommandLineParser extends CommandLineParser {
       // try to evaluate any parameters. This is to ensure that the
       // `--debug` flag is defined correctly before we do this not-so-rigorous
       // parameter parsing.
-      throw new InternalError('onDefineParameters() has not yet been called.');
+      throw new InternalError('parameters have not yet been defined.');
     }
 
     const toolParameters: Set<string> = getToolParameterNamesFromArgs(args);