Log message if formOpenAiToolCalls throws exception

dsgrieve · web-flow · commit 1257fee62505 · 2024-08-07T11:09:51.000-04:00
diff --git a/aiservices/openai/src/main/java/com/microsoft/semantickernel/aiservices/openai/chatcompletion/OpenAIChatCompletion.java b/aiservices/openai/src/main/java/com/microsoft/semantickernel/aiservices/openai/chatcompletion/OpenAIChatCompletion.java
@@ -619,7 +619,8 @@ private Mono<List<OpenAIChatMessageContent<?>>> getChatMessageContentsAsync(
                         null,
                         completionMetadata,
                         formOpenAiToolCalls(response));
-                } catch (Exception e) {
+                } catch (SKCheckedException e) {
+                    LOGGER.warn("Failed to form chat message content", e);
                     return null;
                 }
             })
@@ -936,7 +937,7 @@ private static boolean hasToolCallBeenExecuted(List<ChatRequestMessage> chatRequ
     }
 
     private static List<ChatRequestMessage> getChatRequestMessages(
-        List<? extends ChatMessageContent> messages) {
+        List<? extends ChatMessageContent<?>> messages) {
         if (messages == null || messages.isEmpty()) {
             return new ArrayList<>();
         }

Original file line number	Diff line number	Diff line change
`@@ -619,7 +619,8 @@ private Mono<List<OpenAIChatMessageContent<?>>> getChatMessageContentsAsync(`
`619`	`619`	`null,`
`620`	`620`	`completionMetadata,`
`621`	`621`	`formOpenAiToolCalls(response));`
`622`		`- } catch (Exception e) {`
	`622`	`+ } catch (SKCheckedException e) {`
	`623`	`+ LOGGER.warn("Failed to form chat message content", e);`
`623`	`624`	`return null;`
`624`	`625`	`}`
`625`	`626`	`})`
`@@ -936,7 +937,7 @@ private static boolean hasToolCallBeenExecuted(List<ChatRequestMessage> chatRequ`
`936`	`937`	`}`
`937`	`938`
`938`	`939`	`private static List<ChatRequestMessage> getChatRequestMessages(`
`939`		`- List<? extends ChatMessageContent> messages) {`
	`940`	`+ List<? extends ChatMessageContent<?>> messages) {`
`940`	`941`	`if (messages == null \|\| messages.isEmpty()) {`
`941`	`942`	`return new ArrayList<>();`
`942`	`943`	`}`