Skip to content

Commit 4bfe3e9

Browse files
author
Milder Hernandez
authored
Merge pull request #255 from milderhc/dimensions-bug
Remove default dimensions for models that don't support it
2 parents add005d + 7d9e3f1 commit 4bfe3e9

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

aiservices/openai/src/main/java/com/microsoft/semantickernel/aiservices/openai/textembedding/OpenAITextEmbeddingGenerationService.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ public class OpenAITextEmbeddingGenerationService extends OpenAiService<OpenAIAs
2626

2727
private static final Logger LOGGER = LoggerFactory
2828
.getLogger(OpenAITextEmbeddingGenerationService.class);
29-
private static final int DEFAULT_DIMENSIONS = 1536;
3029
private final int dimensions;
3130

3231
/**
@@ -100,8 +99,10 @@ public Mono<List<Embedding>> generateEmbeddingsAsync(List<String> data) {
10099
protected Mono<List<Embedding>> internalGenerateTextEmbeddingsAsync(List<String> data) {
101100
EmbeddingsOptions options = new EmbeddingsOptions(data)
102101
.setModel(getModelId())
103-
.setDimensions(dimensions)
104102
.setInputType("string");
103+
if (dimensions > 0) {
104+
options.setDimensions(dimensions);
105+
}
105106

106107
return getClient()
107108
.getEmbeddings(getModelId(), options)
@@ -118,7 +119,7 @@ protected Mono<List<Embedding>> internalGenerateTextEmbeddingsAsync(List<String>
118119
public static class Builder extends
119120
OpenAiServiceBuilder<OpenAIAsyncClient, OpenAITextEmbeddingGenerationService, OpenAITextEmbeddingGenerationService.Builder> {
120121

121-
private int dimensions = DEFAULT_DIMENSIONS;
122+
private int dimensions = -1;
122123

123124
/**
124125
* Sets the dimensions for the embeddings.

0 commit comments

Comments
 (0)