Format

Author: Milder Hernandez Cagua

semantickernel-api/src/main/java/com/microsoft/semantickernel/services/audio/AudioToTextService.java

@@ -33,7 +33,8 @@ static Builder builder() {
     /**
      * Builder for the AudioToTextService.
      */
-    abstract class Builder extends OpenAiServiceBuilder<OpenAIAsyncClient, AudioToTextService, Builder> {
+    abstract class Builder
+        extends OpenAiServiceBuilder<OpenAIAsyncClient, AudioToTextService, Builder> {
 
     }
 }

semantickernel-api/src/main/java/com/microsoft/semantickernel/services/openai/OpenAiServiceBuilder.java

@@ -11,8 +11,9 @@
  * @param <T> The service type
  * @param <U> The builder type
 */
-public abstract class OpenAiServiceBuilder<C, T extends AIService, U extends OpenAiServiceBuilder<C, T, U>> implements
- 
+public abstract class OpenAiServiceBuilder<C, T extends AIService, U extends OpenAiServiceBuilder<C, T, U>>
+    implements
+
     SemanticKernelBuilder<T> {
 
     @Nullable

semantickernel-api/src/main/java/com/microsoft/semantickernel/services/textcompletion/TextGenerationService.java

@@ -61,6 +61,7 @@ Flux<StreamingTextContent> getStreamingTextContentsAsync(
     /**
      * Builder for a TextGenerationService
      */
-    abstract class Builder extends OpenAiServiceBuilder<OpenAIAsyncClient, TextGenerationService, Builder> {
+    abstract class Builder
+        extends OpenAiServiceBuilder<OpenAIAsyncClient, TextGenerationService, Builder> {
     }
 }

semantickernel-experimental/src/main/java/com/microsoft/semantickernel/connectors/data/azureaisearch/AzureAISearchVectorStoreRecordCollection.java

@@ -91,14 +91,15 @@ public AzureAISearchVectorStoreRecordCollection(
 
         // Validate supported types
         VectorStoreRecordDefinition.validateSupportedTypes(
-                Collections.singletonList(recordDefinition.getKeyDeclaredField(this.options.getRecordClass())),
-                supportedKeyTypes);
+            Collections
+                .singletonList(recordDefinition.getKeyDeclaredField(this.options.getRecordClass())),
+            supportedKeyTypes);
         VectorStoreRecordDefinition.validateSupportedTypes(
-                recordDefinition.getDataDeclaredFields(this.options.getRecordClass()),
-                supportedDataTypes);
+            recordDefinition.getDataDeclaredFields(this.options.getRecordClass()),
+            supportedDataTypes);
         VectorStoreRecordDefinition.validateSupportedTypes(
-                recordDefinition.getVectorDeclaredFields(this.options.getRecordClass()),
-                supportedVectorTypes);
+            recordDefinition.getVectorDeclaredFields(this.options.getRecordClass()),
+            supportedVectorTypes);
 
         // Add non-vector fields to the list
         nonVectorFields.add(this.recordDefinition.getKeyField().getName());

semantickernel-experimental/src/main/java/com/microsoft/semantickernel/connectors/data/jdbc/JDBCVectorStore.java

@@ -1,15 +1,14 @@
+// Copyright (c) Microsoft. All rights reserved.
 package com.microsoft.semantickernel.connectors.data.jdbc;
 
 import com.microsoft.semantickernel.data.recorddefinition.VectorStoreRecordDefinition;
-import com.microsoft.semantickernel.exceptions.SKException;
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import reactor.core.publisher.Mono;
+import reactor.core.scheduler.Schedulers;
 
 import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
 import java.sql.Connection;
-import java.sql.ResultSet;
-import java.sql.SQLException;
-import java.util.ArrayList;
 import java.util.List;
 
 /**
@@ -27,14 +26,18 @@ public class JDBCVectorStore implements SQLVectorStore<JDBCVectorStoreRecordColl
      * @param connection the connection
      * @param options    the options
      */
-    public JDBCVectorStore(@Nonnull Connection connection, @Nullable JDBCVectorStoreOptions options) {
+    @SuppressFBWarnings("EI_EXPOSE_REP2")
+    public JDBCVectorStore(@Nonnull Connection connection,
+        @Nullable JDBCVectorStoreOptions options) {
         this.connection = connection;
         this.options = options;
 
         if (this.options != null && this.options.getQueryProvider() != null) {
             this.queryProvider = this.options.getQueryProvider();
         } else {
-            this.queryProvider = new JDBCVectorStoreDefaultQueryProvider(connection);
+            this.queryProvider = JDBCVectorStoreDefaultQueryProvider.builder()
+                .withConnection(connection)
+                .build();
         }
     }
 
@@ -57,30 +60,30 @@ public static Builder builder() {
      */
     @Override
     public <Key, Record> JDBCVectorStoreRecordCollection<?> getCollection(
-            @Nonnull String collectionName,
-            @Nonnull Class<Record> recordClass,
-            @Nullable VectorStoreRecordDefinition recordDefinition) {
+        @Nonnull String collectionName,
+        @Nonnull Class<Record> recordClass,
+        @Nullable VectorStoreRecordDefinition recordDefinition) {
 
         if (this.options != null && this.options.getVectorStoreRecordCollectionFactory() != null) {
             return this.options.getVectorStoreRecordCollectionFactory()
                 .createVectorStoreRecordCollection(
                     connection,
                     collectionName,
                     JDBCVectorStoreRecordCollectionOptions.<Record>builder()
-                            .withRecordClass(recordClass)
-                            .withRecordDefinition(recordDefinition)
-                            .withQueryProvider(this.queryProvider)
-                            .build());
-        }
-
-        return new JDBCVectorStoreRecordCollection<>(
-                connection,
-                collectionName,
-                JDBCVectorStoreRecordCollectionOptions.<Record>builder()
                         .withRecordClass(recordClass)
                         .withRecordDefinition(recordDefinition)
                         .withQueryProvider(this.queryProvider)
                         .build());
+        }
+
+        return new JDBCVectorStoreRecordCollection<>(
+            connection,
+            collectionName,
+            JDBCVectorStoreRecordCollectionOptions.<Record>builder()
+                .withRecordClass(recordClass)
+                .withRecordDefinition(recordDefinition)
+                .withQueryProvider(this.queryProvider)
+                .build());
     }
 
     /**
@@ -90,30 +93,17 @@ public <Key, Record> JDBCVectorStoreRecordCollection<?> getCollection(
      */
     @Override
     public Mono<List<String>> getCollectionNamesAsync() {
-        return Mono.fromCallable(() -> {
-            List<String> collectionNames = new ArrayList<>();
-            try {
-                ResultSet resultSet = queryProvider.getCollectionNames();
-                while (resultSet.next()) {
-                    collectionNames.add(resultSet.getString(1));
-                }
-
-                return collectionNames;
-            } catch (SQLException e) {
-                throw new SKException("Failed to get collection names.", e);
-            }
-        });
+        return Mono.fromCallable(queryProvider::getCollectionNames)
+            .subscribeOn(Schedulers.boundedElastic());
     }
 
+    /**
+     * Prepares the vector store.
+     */
     @Override
     public Mono<Void> prepareAsync() {
-        return Mono.fromRunnable(() -> {
-            try {
-                queryProvider.prepareVectorStore();
-            } catch (SQLException e) {
-                throw new SKException("Failed to prepare vector store.", e);
-            }
-        });
+        return Mono.fromRunnable(queryProvider::prepareVectorStore)
+            .subscribeOn(Schedulers.boundedElastic()).then();
     }
 
     /**
@@ -129,6 +119,7 @@ public static class Builder {
          * @param connection the connection
          * @return the builder
          */
+        @SuppressFBWarnings("EI_EXPOSE_REP2")
         public Builder withConnection(Connection connection) {
             this.connection = connection;
             return this;