Skip to content

Commit 5859394

Browse files
author
Milder Hernandez Cagua
committed
Updates to service selector
1 parent 44b27cd commit 5859394

File tree

3 files changed

+5
-30
lines changed

3 files changed

+5
-30
lines changed

semantickernel-api/src/main/java/com/microsoft/semantickernel/services/AIServiceSelector.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,7 @@ public interface AIServiceSelector {
2525
* @param <T> The type of service to select.
2626
* @return An {@code AIServiceSelection} containing the selected service and associated
2727
* PromptExecutionSettings.
28-
*
29-
* @deprecated Use {@link #trySelectAIService(Class, KernelArguments)} instead.
3028
*/
31-
@Deprecated
3229
@Nullable
3330
<T extends AIService> AIServiceSelection<T> trySelectAIService(
3431
Class<T> serviceType,

semantickernel-api/src/main/java/com/microsoft/semantickernel/services/BaseAIServiceSelector.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,7 @@ public <T extends AIService> AIServiceSelection<T> trySelectAIService(
5656
* @param <T> The type of service to select.
5757
* @return The selected service, or {@code null} if no service could be selected.
5858
*
59-
* @deprecated Implement {@link #trySelectAIService(Class, KernelArguments)}
6059
*/
61-
@Deprecated
6260
@Nullable
6361
protected abstract <T extends AIService> AIServiceSelection<T> trySelectAIService(
6462
Class<T> serviceType,
@@ -84,7 +82,6 @@ protected <T extends AIService> AIServiceSelection<T> trySelectAIService(
8482
Class<T> serviceType,
8583
@Nullable KernelArguments arguments,
8684
Map<Class<? extends AIService>, AIService> services) {
87-
throw new UnsupportedOperationException(
88-
"This method is not implemented.");
85+
return trySelectAIService(serviceType, null, arguments, services);
8986
}
9087
}

semantickernel-api/src/main/java/com/microsoft/semantickernel/services/OrderedAIServiceSelector.java

Lines changed: 4 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -57,25 +57,6 @@ private static <T extends AIService> AIServiceSelection<T> castServiceSelection(
5757
}
5858
}
5959

60-
@Nullable
61-
private static Map<String, PromptExecutionSettings> settingsFromFunctionSettings(
62-
@Nullable KernelFunction function) {
63-
if (function != null) {
64-
return function.getExecutionSettings();
65-
}
66-
return null;
67-
}
68-
69-
@Nullable
70-
@Override
71-
public <T extends AIService> AIServiceSelection<T> trySelectAIService(
72-
Class<T> serviceType,
73-
@Nullable KernelArguments arguments,
74-
Map<Class<? extends AIService>, AIService> services) {
75-
76-
return selectAIService(serviceType, arguments != null ? arguments.getExecutionSettings() : null);
77-
}
78-
7960
@Nullable
8061
@Override
8162
public <T extends AIService> AIServiceSelection<T> trySelectAIService(
@@ -84,11 +65,11 @@ public <T extends AIService> AIServiceSelection<T> trySelectAIService(
8465
@Nullable KernelArguments arguments,
8566
Map<Class<? extends AIService>, AIService> services) {
8667

87-
// Allow the execution settings from the kernel arguments to take precedence
88-
Map<String, PromptExecutionSettings> executionSettings = settingsFromFunctionSettings(
89-
function);
68+
if (function == null) {
69+
return selectAIService(serviceType, arguments != null ? arguments.getExecutionSettings() : null);
70+
}
9071

91-
return selectAIService(serviceType, executionSettings);
72+
return selectAIService(serviceType, function.getExecutionSettings());
9273
}
9374

9475

0 commit comments

Comments
 (0)