Skip to content

Commit bf4e93d

Browse files
authored
Merge pull request #291 from pjirsa/main
OpenTelemetry Semantic Convention compliance
2 parents 3c3b2e7 + 016aa22 commit bf4e93d

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

aiservices/openai/src/test/java/com/microsoft/semantickernel/aiservices/openai/OtelCaptureTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,9 +118,9 @@ public void otelChatCaptureTest() {
118118
spans.get(0).getAttributes().get(AttributeKey.stringKey("gen_ai.system")));
119119
Assertions.assertEquals(21,
120120
spans.get(0).getAttributes()
121-
.get(AttributeKey.longKey("gen_ai.response.completion_tokens")));
121+
.get(AttributeKey.longKey("gen_ai.usage.output_tokens")));
122122
Assertions.assertEquals(42,
123123
spans.get(0).getAttributes()
124-
.get(AttributeKey.longKey("gen_ai.response.prompt_tokens")));
124+
.get(AttributeKey.longKey("gen_ai.usage.input_tokens")));
125125
}
126126
}

semantickernel-api/src/main/java/com/microsoft/semantickernel/implementation/telemetry/ChatCompletionSpan.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,8 @@ public void endSpanWithUsage(ChatCompletions chatCompletions) {
104104
CompletionsUsage usage = chatCompletions.getUsage();
105105
getSpan().setStatus(StatusCode.OK);
106106
getSpan()
107-
.setAttribute("gen_ai.response.completion_tokens", usage.getCompletionTokens());
108-
getSpan().setAttribute("gen_ai.response.prompt_tokens", usage.getPromptTokens());
107+
.setAttribute("gen_ai.usage.output_tokens", usage.getCompletionTokens());
108+
getSpan().setAttribute("gen_ai.usage.input_tokens", usage.getPromptTokens());
109109
close();
110110
}
111111

0 commit comments

Comments
 (0)