Skip to content

Commit df5bf06

Browse files
author
Milder Hernandez Cagua
committed
Fix SQLite tests file creation
1 parent a2bfa8b commit df5bf06

File tree

2 files changed

+24
-8
lines changed

2 files changed

+24
-8
lines changed

api-test/integration-tests/src/test/java/com/microsoft/semantickernel/tests/connectors/memory/jdbc/JDBCVectorStoreRecordCollectionTest.java

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
import com.microsoft.semantickernel.data.vectorstorage.options.GetRecordOptions;
1818
import com.microsoft.semantickernel.data.vectorstorage.options.VectorSearchOptions;
1919
import com.mysql.cj.jdbc.MysqlDataSource;
20+
21+
import java.io.IOException;
2022
import java.nio.file.Files;
2123
import java.nio.file.Path;
2224
import java.util.ArrayList;
@@ -61,6 +63,16 @@ public enum QueryProvider {
6163
HSQLDB
6264
}
6365

66+
static Path createTempDbFile(String prefix) {
67+
try {
68+
Path file = Files.createTempFile(prefix, ".db");
69+
file.toFile().deleteOnExit();
70+
return file;
71+
} catch (IOException e) {
72+
throw new RuntimeException(e);
73+
}
74+
}
75+
6476
private JDBCVectorStoreRecordCollection<Hotel> buildRecordCollection(QueryProvider provider,
6577
@Nonnull String collectionName) {
6678
SQLVectorStoreQueryProvider queryProvider;
@@ -88,17 +100,18 @@ private JDBCVectorStoreRecordCollection<Hotel> buildRecordCollection(QueryProvid
88100
.build();
89101
break;
90102
case SQLite:
103+
Path sqliteDb = createTempDbFile("sqliteDb");
91104
SQLiteDataSource sqliteDataSource = new SQLiteDataSource();
92-
sqliteDataSource.setUrl("jdbc:sqlite:file:testdb");
105+
sqliteDataSource.setUrl("jdbc:sqlite:file:" + sqliteDb.toFile().getAbsolutePath());
93106
dataSource = sqliteDataSource;
107+
94108
queryProvider = SQLiteVectorStoreQueryProvider.builder()
95-
.withDataSource(sqliteDataSource)
109+
.withDataSource(dataSource)
96110
.build();
97111
break;
98112
case HSQLDB:
99113
try {
100-
Path file = Files.createTempFile("testdb", ".db");
101-
file.toFile().deleteOnExit();
114+
Path file = createTempDbFile("testHSQLDB");
102115

103116
Properties properties = new Properties();
104117
properties.putAll(

api-test/integration-tests/src/test/java/com/microsoft/semantickernel/tests/connectors/memory/jdbc/JDBCVectorStoreTest.java

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import org.testcontainers.utility.DockerImageName;
2222

2323
import javax.sql.DataSource;
24+
import java.io.IOException;
2425
import java.nio.file.Files;
2526
import java.nio.file.Path;
2627
import java.util.Arrays;
@@ -30,6 +31,7 @@
3031

3132
import com.microsoft.semantickernel.tests.connectors.memory.jdbc.JDBCVectorStoreRecordCollectionTest.QueryProvider;
3233

34+
import static com.microsoft.semantickernel.tests.connectors.memory.jdbc.JDBCVectorStoreRecordCollectionTest.createTempDbFile;
3335
import static org.junit.jupiter.api.Assertions.assertEquals;
3436
import static org.junit.jupiter.api.Assertions.assertNotNull;
3537
import static org.junit.jupiter.api.Assertions.assertTrue;
@@ -72,17 +74,18 @@ private JDBCVectorStore buildVectorStore(QueryProvider provider) {
7274
.build();
7375
break;
7476
case SQLite:
77+
Path sqliteDb = createTempDbFile("testSQLite");
7578
SQLiteDataSource sqliteDataSource = new SQLiteDataSource();
76-
sqliteDataSource.setUrl("jdbc:sqlite:file:test");
79+
sqliteDataSource.setUrl("jdbc:sqlite:file:" + sqliteDb.toFile().getAbsolutePath());
7780
dataSource = sqliteDataSource;
81+
7882
queryProvider = SQLiteVectorStoreQueryProvider.builder()
79-
.withDataSource(sqliteDataSource)
83+
.withDataSource(dataSource)
8084
.build();
8185
break;
8286
case HSQLDB:
8387
try {
84-
Path file = Files.createTempFile("testdb", ".db");
85-
file.toFile().deleteOnExit();
88+
Path file = createTempDbFile("testHSQLDB");
8689

8790
Properties properties = new Properties();
8891
properties.putAll(

0 commit comments

Comments
 (0)